pkg/front_end/lib/src/fasta/kernel/kernel_named_mixin_application_builder.dart - Issue 2788153002: Create separate scopes for constructors, setters, and other members.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_named_mixin_application_builder.dart

Issue 2788153002: Create separate scopes for constructors, setters, and other members. (Closed)

Patch Set: One more flaky standalone/io test. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/kernel_mixin_application_builder.dart ('k') | pkg/front_end/lib/src/fasta/kernel/kernel_target.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/front_end/lib/src/fasta/kernel/kernel_named_mixin_application_builder.dart

diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_named_mixin_application_builder.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_named_mixin_application_builder.dart

index 03786bd614448c0466e86934646777e18cf36683..5ad745e157c2cb55f11e1ad58cedcb47511c35e5 100644

--- a/pkg/front_end/lib/src/fasta/kernel/kernel_named_mixin_application_builder.dart

+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_named_mixin_application_builder.dart

@@ -10,11 +10,12 @@ import '../source/source_class_builder.dart' show SourceClassBuilder;

import 'kernel_builder.dart'

show

- Builder,

KernelTypeBuilder,

LibraryBuilder,

+ MemberBuilder,

MetadataBuilder,

NamedMixinApplicationBuilder,

+ Scope,

TypeVariableBuilder;

class KernelNamedMixinApplicationBuilder extends SourceClassBuilder

@@ -28,8 +29,21 @@ class KernelNamedMixinApplicationBuilder extends SourceClassBuilder

List<KernelTypeBuilder> interfaces,

LibraryBuilder parent,

int charOffset)

- : super(metadata, modifiers, name, typeVariables, mixinApplication,

- interfaces, <String, Builder>{}, parent, null, charOffset);

+ : super(

+ metadata,

+ modifiers,

+ name,

+ typeVariables,

+ mixinApplication,

+ interfaces,

+ new Scope(<String, MemberBuilder>{}, <String, MemberBuilder>{},

+ parent.scope.withTypeVariables(typeVariables),

+ isModifiable: false),

+ new Scope(<String, MemberBuilder>{}, null, null,

+ isModifiable: false),

+ parent,

+ null,

+ charOffset);

KernelTypeBuilder get mixinApplication => supertype;