Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart

Issue 2788153002: Create separate scopes for constructors, setters, and other members. (Closed)
Patch Set: One more flaky standalone/io test. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart b/pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart
index 25336a6ff9b90bd3b6142ade3997c129af839568..b4659448d0f54e9c5cd10a90cd2602f60f4cae73 100644
--- a/pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart
@@ -12,7 +12,7 @@ import 'package:kernel/ast.dart';
import '../errors.dart' show internalError;
-import '../scope.dart' show AccessErrorBuilder, ProblemBuilder;
+import '../scope.dart' show AccessErrorBuilder, ProblemBuilder, Scope;
import 'frontend_accessors.dart' as kernel
show
@@ -43,7 +43,7 @@ abstract class BuilderHelper {
Member lookupSuperMember(Name name, {bool isSetter: false});
- builderToFirstExpression(Builder builder, String name, int offset);
+ scopeLookup(Scope scope, String name, int offset, {bool isQualified: false});
finishSend(Object receiver, Arguments arguments, int offset);
@@ -431,8 +431,8 @@ class SendAccessor extends IncompleteSend {
}
if (receiver is PrefixBuilder) {
PrefixBuilder prefix = receiver;
- receiver = helper.builderToFirstExpression(
- prefix.exports[name.name], "${prefix.name}.${name.name}", offset);
+ receiver = helper.scopeLookup(prefix.exports, name.name, offset,
+ isQualified: true);
return helper.finishSend(receiver, arguments, offset);
}
Expression result;
@@ -517,8 +517,8 @@ class IncompletePropertyAccessor extends IncompleteSend {
}
if (receiver is PrefixBuilder) {
PrefixBuilder prefix = receiver;
- return helper.builderToFirstExpression(
- prefix.exports[name.name], name.name, offset);
+ return helper.scopeLookup(prefix.exports, name.name, offset,
+ isQualified: true);
}
if (receiver is KernelClassBuilder) {
Builder builder = receiver.findStaticBuilder(name.name, offset, uri);
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/body_builder.dart ('k') | pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698