Create separate scopes for constructors, setters, and other members.

pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library fasta.fasta_accessors;
 
 export 'package:kernel/frontend/accessors.dart' show wrapInvalid;
 
 import 'package:kernel/frontend/accessors.dart'
     show Accessor, buildIsNull, makeLet;
 
 import 'package:kernel/ast.dart';
 
 import '../errors.dart' show internalError;
 
-import '../scope.dart' show AccessErrorBuilder, ProblemBuilder;
+import '../scope.dart' show AccessErrorBuilder, ProblemBuilder, Scope;
 
 import 'package:kernel/frontend/accessors.dart' as kernel
     show
         IndexAccessor,
         NullAwarePropertyAccessor,
         PropertyAccessor,
         ReadOnlyAccessor,
         StaticAccessor,
         SuperIndexAccessor,
         SuperPropertyAccessor,
@@ skipping 10 matching lines @@
   Uri get uri;
 
   Constructor lookupConstructor(Name name, {bool isSuper});
 
   Expression toSuperMethodInvocation(MethodInvocation node);
 
   Expression toValue(node);
 
   Member lookupSuperMember(Name name, {bool isSetter: false});
 
-  builderToFirstExpression(Builder builder, String name, int offset);
+  scopeLookup(Scope scope, String name, int offset, {bool isQualified: false});
 
   finishSend(Object receiver, Arguments arguments, int offset);
 
   Expression buildCompileTimeError(error, [int offset]);
 
   Initializer buildCompileTimeErrorIntializer(error, [int offset]);
 
   Expression buildStaticInvocation(Procedure target, Arguments arguments);
 
   Expression buildProblemExpression(ProblemBuilder builder, int offset);
@@ skipping 367 matching lines @@
     if (receiver is TypeDeclarationBuilder) {
       /// `SomeType?.toString` is the same as `SomeType.toString`, not
       /// `(SomeType).toString`.
       isNullAware = false;
     }
     if (receiver is FastaAccessor) {
       return receiver.buildPropertyAccess(this, isNullAware);
     }
     if (receiver is PrefixBuilder) {
       PrefixBuilder prefix = receiver;
-      receiver = helper.builderToFirstExpression(
-          prefix.exports[name.name], "${prefix.name}.${name.name}", offset);
+      receiver = helper.scopeLookup(prefix.exports, name.name, offset,
+          isQualified: true);
       return helper.finishSend(receiver, arguments, offset);
     }
     Expression result;
     if (receiver is KernelClassBuilder) {
       Builder builder = receiver.findStaticBuilder(name.name, offset, uri);
       if (builder == null || builder is AccessErrorBuilder) {
         return buildThrowNoSuchMethodError(arguments);
       }
       if (builder.hasProblem) {
         result = helper.buildProblemExpression(builder, offset);
@@ skipping 64 matching lines @@
       /// For reasons beyond comprehension, `SomeType?.toString` is the same as
       /// `SomeType.toString`, not `(SomeType).toString`. WTAF!?!
       //
       isNullAware = false;
     }
     if (receiver is FastaAccessor) {
       return receiver.buildPropertyAccess(this, isNullAware);
     }
     if (receiver is PrefixBuilder) {
       PrefixBuilder prefix = receiver;
-      return helper.builderToFirstExpression(
-          prefix.exports[name.name], name.name, offset);
+      return helper.scopeLookup(prefix.exports, name.name, offset,
+          isQualified: true);
     }
     if (receiver is KernelClassBuilder) {
       Builder builder = receiver.findStaticBuilder(name.name, offset, uri);
       if (builder == null) {
         // If we find a setter, [builder] is an [AccessErrorBuilder], not null.
         return buildThrowNoSuchMethodError(new Arguments.empty(),
             isGetter: true);
       }
       Builder setter;
       if (builder.isSetter) {
@@ skipping 339 matching lines @@
         new ConditionalExpression(
             buildIsNull(new VariableGet(variable)),
             new NullLiteral(),
             new MethodInvocation(new VariableGet(variable), name, arguments)
               ..fileOffset = offset,
             const DynamicType()));
   } else {
     return new MethodInvocation(receiver, name, arguments)..fileOffset = offset;
   }
 }