Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: Source/core/dom/IdTargetObserver.h

Issue 278803002: Oilpan: Prepare to move IdTargetObserver and IdTargetObserverRegistry to Oilpan heap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/dom/IdTargetObserver.cpp » ('j') | Source/core/dom/IdTargetObserverRegistry.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/IdTargetObserver.h
diff --git a/Source/core/dom/IdTargetObserver.h b/Source/core/dom/IdTargetObserver.h
index 1fc4cd6f57520d79965e372712e91ede0dfd34f8..25c70217397676b5478e31dc0bff7084aad38848 100644
--- a/Source/core/dom/IdTargetObserver.h
+++ b/Source/core/dom/IdTargetObserver.h
@@ -26,15 +26,17 @@
#ifndef IdTargetObserver_h
#define IdTargetObserver_h
+#include "platform/heap/Handle.h"
#include "wtf/text/AtomicString.h"
namespace WebCore {
class IdTargetObserverRegistry;
-class IdTargetObserver {
+class IdTargetObserver : public NoBaseWillBeGarbageCollectedFinalized<IdTargetObserver> {
public:
virtual ~IdTargetObserver();
+ virtual void trace(Visitor*);
virtual void idTargetChanged() = 0;
virtual void unregister();
@@ -42,7 +44,7 @@ protected:
IdTargetObserver(IdTargetObserverRegistry&, const AtomicString& id);
private:
- IdTargetObserverRegistry& m_registry;
+ RawPtrWillBeMember<IdTargetObserverRegistry> m_registry;
wibling-chromium 2014/05/09 08:23:47 NIT: Have you considered adding a IdTargetObserver
tkent 2014/05/09 09:37:20 Added |IdTargetObserverRegistry& registry()| in th
AtomicString m_id;
};
« no previous file with comments | « no previous file | Source/core/dom/IdTargetObserver.cpp » ('j') | Source/core/dom/IdTargetObserverRegistry.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698