third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc - Issue 2788013003: Expected Queueing Time Metric ignores tasks with nested message loops.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

Issue 2788013003: Expected Queueing Time Metric ignores tasks with nested message loops. (Closed)

Patch Set: Address nits Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h ('k') | third_party/WebKit/public/platform/scheduler/base/task_time_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

index fe476ff8ad6e49f284c865eed04c4ecc92a8b6fd..9d9c06aaa466b0222eeba4a6990c4de1a93c4f9a 100644

--- a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

+++ b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

@@ -1785,6 +1785,12 @@ void RendererSchedulerImpl::didProcessTask(TaskQueue* task_queue,

static_cast<int>(TaskQueue::QueueType::COUNT));

}

+void RendererSchedulerImpl::onBeginNestedMessageLoop() {

+ seqlock_queueing_time_estimator_.seqlock.WriteBegin();

+ seqlock_queueing_time_estimator_.data.OnBeginNestedMessageLoop();

+ seqlock_queueing_time_estimator_.seqlock.WriteEnd();

void RendererSchedulerImpl::AddTaskTimeObserver(

TaskTimeObserver* task_time_observer) {

helper_.AddTaskTimeObserver(task_time_observer);