third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc - Issue 2788013003: Expected Queueing Time Metric ignores tasks with nested message loops.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

Issue 2788013003: Expected Queueing Time Metric ignores tasks with nested message loops. (Closed)

Patch Set: Address nits Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scheduler/base/queueing_time_estimator_unittest.cc ('k') | third_party/WebKit/Source/platform/scheduler/base/test_task_time_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

diff --git a/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc b/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

index 49fd2f89237d79afa9f7c8a525b55e28f2b0f0fa..7a0de90fed81345d5cd54e7a021358fbd0e59aac 100644

--- a/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

+++ b/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

@@ -188,6 +188,12 @@ void TaskQueueManager::OnBeginNestedMessageLoop() {

any_thread().immediate_do_work_posted_count++;

any_thread().is_nested = true;

}

+ // When a nested message loop starts, task time observers may want to ignore

+ // the current task.

+ for (auto& observer : task_time_observers_)

+ observer.onBeginNestedMessageLoop();

delegate_->PostTask(FROM_HERE, immediate_do_work_closure_);

}