Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java

Issue 2787963003: WebView: Refactor PlatformServiceBridge.getInstance (Closed)
Patch Set: volatile sInstance and comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java
diff --git a/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java b/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java
index 9be1b7715df5ec5c8b5fe712a957efade1803d03..3e1178e9a6d58a737cfc8bfa8bac495ef00e9878 100644
--- a/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java
+++ b/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java
@@ -76,13 +76,14 @@ public class AwMinidumpUploaderDelegate implements MinidumpUploaderDelegate {
@Override
public void prepareToUploadMinidumps(final Runnable startUploads) {
- createPlatformServiceBridge().queryMetricsSetting(new ValueCallback<Boolean>() {
- public void onReceiveValue(Boolean enabled) {
- ThreadUtils.assertOnUiThread();
- mPermittedByUser = enabled;
- startUploads.run();
- }
- });
+ PlatformServiceBridge.getOrCreateInstance(mContext).queryMetricsSetting(
+ new ValueCallback<Boolean>() {
+ public void onReceiveValue(Boolean enabled) {
+ ThreadUtils.assertOnUiThread();
+ mPermittedByUser = enabled;
+ startUploads.run();
+ }
+ });
}
@Override
@@ -90,13 +91,4 @@ public class AwMinidumpUploaderDelegate implements MinidumpUploaderDelegate {
@Override
public void recordUploadFailure(File minidump) {}
-
- /**
- * Utility method to allow us to test the logic of this class by injecting
- * a test-specific PlatformServiceBridge.
- */
- @VisibleForTesting
- public PlatformServiceBridge createPlatformServiceBridge() {
- return PlatformServiceBridge.getInstance(mContext);
- }
}

Powered by Google App Engine
This is Rietveld 408576698