Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1554)

Unified Diff: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java

Issue 2787963003: WebView: Refactor PlatformServiceBridge.getInstance (Closed)
Patch Set: volatile sInstance and comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/java/src/org/chromium/android_webview/AwMetricsLogUploader.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
diff --git a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
index dd5951fda786f115e10b37f5630957a80a43c4a7..7f51314d61d363d01eefc95a8e8ac77bc1677200 100644
--- a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
+++ b/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
@@ -402,10 +402,13 @@ public class WebViewChromiumFactoryProvider implements WebViewFactoryProvider {
PathService.override(PathService.DIR_MODULE, "/system/lib/");
PathService.override(DIR_RESOURCE_PAKS_ANDROID, "/system/framework/webview/paks");
+ final Context context = ContextUtils.getApplicationContext();
+ // Future calls to PlatformServiceBridge.getInstance() rely on it having been created here.
+ PlatformServiceBridge.getOrCreateInstance(context);
+
// Make sure that ResourceProvider is initialized before starting the browser process.
final PackageInfo webViewPackageInfo = WebViewFactory.getLoadedPackageInfo();
final String webViewPackageName = webViewPackageInfo.packageName;
- final Context context = ContextUtils.getApplicationContext();
setUpResources(webViewPackageInfo, context);
initPlatSupportLibrary();
doNetworkInitializations(context);
@@ -419,18 +422,17 @@ public class WebViewChromiumFactoryProvider implements WebViewFactoryProvider {
AwBrowserProcess.handleMinidumps(webViewPackageName, true /* enabled */);
}
- // Actions conditioned on whether the Android Checkbox is toggled on
- PlatformServiceBridge.getInstance(context)
- .queryMetricsSetting(new ValueCallback<Boolean>() {
- public void onReceiveValue(Boolean enabled) {
- ThreadUtils.assertOnUiThread();
- AwMetricsServiceClient.setConsentSetting(context, enabled);
+ PlatformServiceBridge.getInstance().queryMetricsSetting(new ValueCallback<Boolean>() {
+ // Actions conditioned on whether the Android Checkbox is toggled on
+ public void onReceiveValue(Boolean enabled) {
+ ThreadUtils.assertOnUiThread();
+ AwMetricsServiceClient.setConsentSetting(context, enabled);
- if (!enableMinidumpUploadingForTesting) {
- AwBrowserProcess.handleMinidumps(webViewPackageName, enabled);
- }
- }
- });
+ if (!enableMinidumpUploadingForTesting) {
+ AwBrowserProcess.handleMinidumps(webViewPackageName, enabled);
+ }
+ }
+ });
if (CommandLineUtil.isBuildDebuggable()) {
setWebContentsDebuggingEnabled(true);
« no previous file with comments | « no previous file | android_webview/java/src/org/chromium/android_webview/AwMetricsLogUploader.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698