android_webview/java/src/org/chromium/android_webview/AwMetricsLogUploader.java - Issue 2787963003: WebView: Refactor PlatformServiceBridge.getInstance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwMetricsLogUploader.java

Issue 2787963003: WebView: Refactor PlatformServiceBridge.getInstance (Closed)

Patch Set: make injectInstance less picky Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java ('K') | « android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java ('k') | android_webview/java/src/org/chromium/android_webview/PlatformServiceBridge.java » ('j') | android_webview/java/src/org/chromium/android_webview/PlatformServiceBridge.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwMetricsLogUploader.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwMetricsLogUploader.java b/android_webview/java/src/org/chromium/android_webview/AwMetricsLogUploader.java

index 09e0b42750c80da05510fb76c78bc5c95e3c6e21..f7a4611ef9a977d63d9a4f19ba3cf0cc66f591e4 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwMetricsLogUploader.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwMetricsLogUploader.java

@@ -14,8 +14,6 @@ import org.chromium.base.annotations.JNINamespace;

public class AwMetricsLogUploader {

@CalledByNative

public static void uploadLog(byte[] data) {

- // getInstance only needs a Context on the first call. WebViewChromiumFactoryProvider will

- // have already called it, so we can pass null here.

- PlatformServiceBridge.getInstance(null).logMetrics(data);

+ PlatformServiceBridge.getInstance().logMetrics(data);

}