Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: third_party/WebKit/LayoutTests/imagecapture/getphotocapabilities.html

Issue 2787933002: ImageCapture: separate fillLightMode, redEyeReduction and Torch (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/imagecapture/getphotocapabilities.html
diff --git a/third_party/WebKit/LayoutTests/imagecapture/getphotocapabilities.html b/third_party/WebKit/LayoutTests/imagecapture/getphotocapabilities.html
index 49b8c370c9bf903788e62007f356779e16d7568b..a58c0c3723c69e8ffb8207e2b5ef2759bb88c7e7 100644
--- a/third_party/WebKit/LayoutTests/imagecapture/getphotocapabilities.html
+++ b/third_party/WebKit/LayoutTests/imagecapture/getphotocapabilities.html
@@ -8,8 +8,6 @@
</body>
<script>
-const mojoFillLightModeNames = ["none", "off", "auto", "flash"];
-
// This test verifies that ImageCapture can get PhotoCapabilities(), with a mock
// Mojo interface implementation.
@@ -36,6 +34,9 @@ async_test(function(t) {
.then(capabilities => {
assert_true(capabilities instanceof PhotoCapabilities);
+ assert_equals(capabilities.redEyeReduction, 'controllable',
+ 'redEyeReduction');
+
assert_true(capabilities.imageHeight instanceof MediaSettingsRange);
assert_equals(capabilities.imageHeight.max,
mock_capabilities.height.max);
@@ -55,13 +56,8 @@ async_test(function(t) {
mock_capabilities.width.current);
assert_equals(capabilities.imageWidth.step, mock_capabilities.width.step);
- assert_array_equals(
- capabilities.fillLightMode,
- [mojoFillLightModeNames[mock_capabilities.fill_light_mode]],
- 'fillLightMode');
-
- assert_equals(capabilities.redEyeReduction, 'controllable',
- 'redEyeReduction');
+ assert_array_equals(capabilities.fillLightMode, [ 'auto', 'flash' ],
+ 'fillLightMode');
t.done();
})

Powered by Google App Engine
This is Rietveld 408576698