Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 278793002: Correct task items' icon position in RTL languages. (Closed)

Created:
6 years, 7 months ago by fukino
Modified:
6 years, 7 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Correct task items' layout for RTL languages. This CL fixes task items' layout problem in action button (as combobutton) and default task (in context menu). In the screenshot attached in issue 371232, these problems are pointed as "Icon position of task menu is strange.". For margin and padding, I used -webkit-margin-start etc.. For background position, I used separate selector for html in 'rtl'. BUG=371232 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269546

Patch Set 1 #

Patch Set 2 : Use single quotation in CSS selectors. #

Total comments: 4

Patch Set 3 : Sort property names. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M ui/file_manager/file_manager/foreground/css/combobutton.css View 1 2 1 chunk +8 lines, -4 lines 0 comments Download
M ui/file_manager/file_manager/foreground/css/common.css View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
fukino
hirono san, could you take a look?
6 years, 7 months ago (2014-05-09 05:29:24 UTC) #1
hirono
lgtm with two nits. Thank you! https://codereview.chromium.org/278793002/diff/20001/ui/file_manager/file_manager/foreground/css/combobutton.css File ui/file_manager/file_manager/foreground/css/combobutton.css (right): https://codereview.chromium.org/278793002/diff/20001/ui/file_manager/file_manager/foreground/css/combobutton.css#newcode14 ui/file_manager/file_manager/foreground/css/combobutton.css:14: -webkit-padding-start: 21px; -webkit-xxx ...
6 years, 7 months ago (2014-05-09 05:46:35 UTC) #2
fukino
Sorted selectors. Thank you very much! https://codereview.chromium.org/278793002/diff/20001/ui/file_manager/file_manager/foreground/css/combobutton.css File ui/file_manager/file_manager/foreground/css/combobutton.css (right): https://codereview.chromium.org/278793002/diff/20001/ui/file_manager/file_manager/foreground/css/combobutton.css#newcode14 ui/file_manager/file_manager/foreground/css/combobutton.css:14: -webkit-padding-start: 21px; On ...
6 years, 7 months ago (2014-05-09 05:54:30 UTC) #3
fukino
On 2014/05/09 05:54:30, fukino wrote: > Sorted selectors. > Thank you very much! > > ...
6 years, 7 months ago (2014-05-09 05:57:42 UTC) #4
fukino
The CQ bit was checked by fukino@chromium.org
6 years, 7 months ago (2014-05-09 05:58:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/278793002/40001
6 years, 7 months ago (2014-05-09 06:02:47 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 06:30:44 UTC) #7
Message was sent while issue was closed.
Change committed as 269546

Powered by Google App Engine
This is Rietveld 408576698