Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Unified Diff: chrome/browser/resources/settings/device_page/layout_behavior.js

Issue 2787923002: [MD settings] small code health changes (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/people_page/sync_page.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/device_page/layout_behavior.js
diff --git a/chrome/browser/resources/settings/device_page/layout_behavior.js b/chrome/browser/resources/settings/device_page/layout_behavior.js
index dcea057a8a4d36e44ea6cf9375111e5845b7ee4d..77a56a3fc0e35b5d52bd0df21790caff1c51c800 100644
--- a/chrome/browser/resources/settings/device_page/layout_behavior.js
+++ b/chrome/browser/resources/settings/device_page/layout_behavior.js
@@ -36,7 +36,7 @@ var LayoutBehavior = {
calculatedBoundsMap_: new Map(),
/** @private {string} */
- dragLayoutId: '',
+ dragLayoutId_: '',
/** @private {string} */
dragParentId_: '',
@@ -52,7 +52,7 @@ var LayoutBehavior = {
* @param {!Array<!chrome.system.display.DisplayLayout>} layouts
*/
initializeDisplayLayout: function(displays, layouts) {
- this.dragLayoutId = '';
+ this.dragLayoutId_ = '';
this.dragParentId_ = '';
this.mirroring = displays.length > 0 && !!displays[0].mirroringSourceId;
@@ -85,7 +85,7 @@ var LayoutBehavior = {
* @return {!chrome.system.display.Bounds}
*/
updateDisplayBounds: function(id, newBounds) {
- this.dragLayoutId = id;
+ this.dragLayoutId_ = id;
// Find the closest parent.
var closestId = this.findClosest_(id, newBounds);
@@ -134,7 +134,7 @@ var LayoutBehavior = {
*/
finishUpdateDisplayBounds: function(id) {
this.highlightEdge_('', undefined); // Remove any highlights.
- if (id != this.dragLayoutId || !this.dragBounds_ ||
+ if (id != this.dragLayoutId_ || !this.dragBounds_ ||
!this.dragLayoutPosition_) {
return;
}
« no previous file with comments | « no previous file | chrome/browser/resources/settings/people_page/sync_page.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698