[MD settings] small code health changes

chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Only used for tests.
  * @typedef {{
  *   auto_downloads: !Array<!RawSiteException>},
  *   background_sync: !Array<!RawSiteException>},
  *   camera: !Array<!RawSiteException>},
@@ skipping 79 matching lines @@
     'removeProtocolHandler',
     'removeUsbDevice',
     'removeZoomLevel',
     'resetCategoryPermissionForOrigin',
     'setCategoryPermissionForOrigin',
     'setDefaultValueForContentType',
     'setProtocolDefault'
   ]);
 
   /** @private {boolean} */
-  this.hasIncognito = false;
+  this.hasIncognito_ = false;
 
   /** @private {!SiteSettingsPref} */
   this.prefs_ = prefsEmpty;
 
   /** @private {!Array<ZoomLevelEntry>} */
   this.zoomList_ = [];
 
   /** @private {!Array<!UsbDeviceEntry>} */
   this.usbDevices_ = [];
 
   /** @private {!Array<!ProtocolEntry>} */
   this.protocolHandlers_ = [];
 
   /** @private {?CookieList} */
   this.cookieDetails_ = null;
 
   /** @private {boolean} */
   this.isPatternValid_ = true;
 };
 
 TestSiteSettingsPrefsBrowserProxy.prototype = {
   __proto__: settings.TestBrowserProxy.prototype,
 
   /**
    * Pretends an incognito session started or ended.
    * @param {boolean} hasIncognito True for session started.
    */
   setIncognito: function(hasIncognito) {
-    this.hasIncognito = hasIncognito;
+    this.hasIncognito_ = hasIncognito;
     cr.webUIListenerCallback('onIncognitoStatusChanged', hasIncognito);
   },
 
   /**
    * Sets the prefs to use when testing.
    * @param {!SiteSettingsPref} prefs The prefs to set.
    */
   setPrefs: function(prefs) {
     this.prefs_ = prefs;
 
@@ skipping 132 matching lines @@
     else if (contentType == settings.ContentSettingsTypes.UNSANDBOXED_PLUGINS)
       pref = this.prefs_.exceptions.unsandboxed_plugins;
     else if (contentType == settings.ContentSettingsTypes.SUBRESOURCE_FILTER) {
       pref = this.prefs_.exceptions.subresource_filter;
     }
     else
       console.log('getExceptionList received unknown category: ' + contentType);
 
     assert(pref != undefined, 'Pref is missing for ' + contentType);
 
-    if (this.hasIncognito) {
+    if (this.hasIncognito_) {
       var incognitoElements = [];
       for (var i = 0; i < pref.length; ++i)
         incognitoElements.push(Object.assign({incognito: true}, pref[i]));
       pref = pref.concat(incognitoElements);
     }
 
     return Promise.resolve(pref);
   },
 
   /** @override */
@@ skipping 73 matching lines @@
   /** @override */
   setProtocolDefault: function() {
     this.methodCalled('setProtocolDefault', arguments);
   },
 
   /** @override */
   removeProtocolHandler: function() {
     this.methodCalled('removeProtocolHandler', arguments);
   }
 };