Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Unified Diff: components/history/core/browser/typed_url_syncable_service.h

Issue 2787893003: [Sync] TypedUrlSyncableService should filter expired visits from local (Closed)
Patch Set: more verify Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history/core/browser/typed_url_syncable_service.h
diff --git a/components/history/core/browser/typed_url_syncable_service.h b/components/history/core/browser/typed_url_syncable_service.h
index 2cbc0c26bdf690fa98bdc3e452ba22dd0636b44e..39f2fd53da9c1fb112527d46e2bd2f980f84ebb6 100644
--- a/components/history/core/browser/typed_url_syncable_service.h
+++ b/components/history/core/browser/typed_url_syncable_service.h
@@ -184,9 +184,12 @@ class TypedUrlSyncableService : public syncer::SyncableService,
// function compensates for the fact that the history DB has rather poor data
// integrity (duplicate visits, visit timestamps that don't match the
// last_visit timestamp, huge data sets that exhaust memory when fetched,
- // etc) by modifying the passed |url| object and |visits| vector.
- // Returns false if we could not fetch the visits for the passed URL, and
- // tracks DB error statistics internally for reporting via UMA.
+ // expired visits that are not deleted by |ExpireHistoryBackend|, etc) by
+ // modifying the passed |url| object and |visits| vector.
+ // Returns false in two cases.
+ // 1. we could not fetch the visits for the passed URL, and tracks DB error
+ // statistics internally for reporting via UMA.
+ // 2. All the visits are expired.
virtual bool FixupURLAndGetVisits(URLRow* url, VisitVector* visits);
// Given a typed URL in the sync DB, looks for an existing entry in the

Powered by Google App Engine
This is Rietveld 408576698