Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1696)

Unified Diff: content/browser/service_worker/embedded_worker_registry.h

Issue 2787883003: [ServiceWorker] Add EmbeddedWorkerInstanceHost Interface. (Closed)
Patch Set: Refine code comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/embedded_worker_registry.h
diff --git a/content/browser/service_worker/embedded_worker_registry.h b/content/browser/service_worker/embedded_worker_registry.h
index 14bd8b8b44ed3c4bb9de34a3763871ccafc09e43..897d23b565e4eae2d4698ca5975d3336a5fc819c 100644
--- a/content/browser/service_worker/embedded_worker_registry.h
+++ b/content/browser/service_worker/embedded_worker_registry.h
@@ -19,8 +19,6 @@
#include "content/common/content_export.h"
#include "content/common/service_worker/service_worker_status_code.h"
-class GURL;
-
namespace IPC {
class Message;
}
@@ -53,37 +51,13 @@ class CONTENT_EXPORT EmbeddedWorkerRegistry
// This doesn't actually start or stop the worker.
std::unique_ptr<EmbeddedWorkerInstance> CreateWorker();
- // Called from EmbeddedWorkerInstance, relayed to the child process.
- ServiceWorkerStatusCode StopWorker(int process_id,
- int embedded_worker_id);
-
// Stop all active workers, even if they're handling events.
void Shutdown();
- // Called back from EmbeddedWorker in the child process, relayed via
- // ServiceWorkerDispatcherHost.
- void OnWorkerReadyForInspection(int process_id, int embedded_worker_id);
- void OnWorkerScriptLoaded(int process_id, int embedded_worker_id);
- void OnWorkerThreadStarted(int process_id,
- int thread_id,
- int embedded_worker_id);
- void OnWorkerScriptLoadFailed(int process_id, int embedded_worker_id);
- void OnWorkerScriptEvaluated(int process_id,
- int embedded_worker_id,
- bool success);
- void OnWorkerStarted(int process_id, int embedded_worker_id);
+ // Called by EmbeddedWorkerInstance to do some necessary work in the registry.
+ bool OnWorkerStarted(int process_id, int embedded_worker_id);
void OnWorkerStopped(int process_id, int embedded_worker_id);
- void OnReportException(int embedded_worker_id,
- const base::string16& error_message,
- int line_number,
- int column_number,
- const GURL& source_url);
- void OnReportConsoleMessage(int embedded_worker_id,
- int source_identifier,
- int message_level,
- const base::string16& message,
- int line_number,
- const GURL& source_url);
+
// Called by EmbeddedWorkerInstance when it learns DevTools has attached to
// it.
void OnDevToolsAttached(int embedded_worker_id);

Powered by Google App Engine
This is Rietveld 408576698