Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: content/browser/service_worker/embedded_worker_test_helper.cc

Issue 2787883003: [ServiceWorker] Add EmbeddedWorkerInstanceHost Interface. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/embedded_worker_test_helper.cc
diff --git a/content/browser/service_worker/embedded_worker_test_helper.cc b/content/browser/service_worker/embedded_worker_test_helper.cc
index 8103b7451172c61d84b9638a3bdd7c1092eae4ab..b88bc66de61f79e93518b4418de1422ad96d2659 100644
--- a/content/browser/service_worker/embedded_worker_test_helper.cc
+++ b/content/browser/service_worker/embedded_worker_test_helper.cc
@@ -13,6 +13,7 @@
#include "base/atomic_sequence_num.h"
#include "base/bind.h"
#include "base/memory/ptr_util.h"
+#include "base/run_loop.h"
#include "base/threading/thread_task_runner_handle.h"
#include "base/time/time.h"
#include "content/browser/service_worker/embedded_worker_instance.h"
@@ -71,7 +72,8 @@ EmbeddedWorkerTestHelper::MockEmbeddedWorkerInstanceClient::
void EmbeddedWorkerTestHelper::MockEmbeddedWorkerInstanceClient::StartWorker(
const EmbeddedWorkerStartParams& params,
- mojom::ServiceWorkerEventDispatcherRequest dispatcher_request) {
+ mojom::ServiceWorkerEventDispatcherRequest dispatcher_request,
+ mojom::EmbeddedWorkerInstanceHostAssociatedPtrInfo instance_host) {
if (!helper_)
return;
@@ -82,7 +84,8 @@ void EmbeddedWorkerTestHelper::MockEmbeddedWorkerInstanceClient::StartWorker(
ASSERT_TRUE(worker);
EXPECT_EQ(EmbeddedWorkerStatus::STARTING, worker->status());
- helper_->OnStartWorkerStub(params, std::move(dispatcher_request));
+ helper_->OnStartWorkerStub(params, std::move(dispatcher_request),
+ std::move(instance_host));
}
void EmbeddedWorkerTestHelper::MockEmbeddedWorkerInstanceClient::StopWorker(
@@ -371,7 +374,8 @@ void EmbeddedWorkerTestHelper::OnStartWorker(
const GURL& scope,
const GURL& script_url,
bool pause_after_download,
- mojom::ServiceWorkerEventDispatcherRequest request) {
+ mojom::ServiceWorkerEventDispatcherRequest request,
+ mojom::EmbeddedWorkerInstanceHostAssociatedPtrInfo instance_host) {
EmbeddedWorkerInstance* worker = registry()->GetWorker(embedded_worker_id);
ASSERT_TRUE(worker);
MockServiceWorkerEventDispatcher::Create(AsWeakPtr(), worker->thread_id(),
@@ -379,6 +383,8 @@ void EmbeddedWorkerTestHelper::OnStartWorker(
embedded_worker_id_service_worker_version_id_map_[embedded_worker_id] =
service_worker_version_id;
+ embedded_worker_id_instance_host_ptr_map_[embedded_worker_id].Bind(
+ std::move(instance_host));
SimulateWorkerReadyForInspection(embedded_worker_id);
SimulateWorkerScriptCached(embedded_worker_id);
SimulateWorkerScriptLoaded(embedded_worker_id);
@@ -528,8 +534,10 @@ void EmbeddedWorkerTestHelper::SimulateWorkerReadyForInspection(
int embedded_worker_id) {
EmbeddedWorkerInstance* worker = registry()->GetWorker(embedded_worker_id);
ASSERT_TRUE(worker);
- registry()->OnWorkerReadyForInspection(worker->process_id(),
- embedded_worker_id);
+ ASSERT_TRUE(embedded_worker_id_instance_host_ptr_map_[embedded_worker_id]);
+ embedded_worker_id_instance_host_ptr_map_[embedded_worker_id]
+ ->OnReadyForInspection();
+ base::RunLoop().RunUntilIdle();
}
void EmbeddedWorkerTestHelper::SimulateWorkerScriptCached(
@@ -597,7 +605,8 @@ void EmbeddedWorkerTestHelper::SimulateSend(IPC::Message* message) {
void EmbeddedWorkerTestHelper::OnStartWorkerStub(
const EmbeddedWorkerStartParams& params,
- mojom::ServiceWorkerEventDispatcherRequest request) {
+ mojom::ServiceWorkerEventDispatcherRequest request,
+ mojom::EmbeddedWorkerInstanceHostAssociatedPtrInfo instance_host) {
EmbeddedWorkerInstance* worker =
registry()->GetWorker(params.embedded_worker_id);
ASSERT_TRUE(worker);
@@ -607,7 +616,7 @@ void EmbeddedWorkerTestHelper::OnStartWorkerStub(
base::Bind(&EmbeddedWorkerTestHelper::OnStartWorker, AsWeakPtr(),
params.embedded_worker_id, params.service_worker_version_id,
params.scope, params.script_url, params.pause_after_download,
- base::Passed(&request)));
+ base::Passed(&request), base::Passed(&instance_host)));
}
void EmbeddedWorkerTestHelper::OnResumeAfterDownloadStub(

Powered by Google App Engine
This is Rietveld 408576698