Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: content/browser/service_worker/service_worker_context_unittest.cc

Issue 2787883003: [ServiceWorker] Add EmbeddedWorkerInstanceHost Interface. (Closed)
Patch Set: Fix test: ServiceWorkerContextTest.UnregisterMultiple Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_context_unittest.cc
diff --git a/content/browser/service_worker/service_worker_context_unittest.cc b/content/browser/service_worker/service_worker_context_unittest.cc
index 1a49d8bc99a4354c31a417d87e74ffcc721c700a..c67ace328fce3d809035ab987c8c155d0c91aafb 100644
--- a/content/browser/service_worker/service_worker_context_unittest.cc
+++ b/content/browser/service_worker/service_worker_context_unittest.cc
@@ -176,12 +176,13 @@ class RecordableEmbeddedWorkerInstanceClient
const std::vector<Message>& events() const { return events_; }
protected:
- void StartWorker(
- const EmbeddedWorkerStartParams& params,
- mojom::ServiceWorkerEventDispatcherRequest request) override {
+ void StartWorker(const EmbeddedWorkerStartParams& params,
+ mojom::ServiceWorkerEventDispatcherRequest request,
+ mojom::EmbeddedWorkerInstanceHostAssociatedPtrInfo
+ instance_host) override {
events_.push_back(Message::StartWorker);
EmbeddedWorkerTestHelper::MockEmbeddedWorkerInstanceClient::StartWorker(
- params, std::move(request));
+ params, std::move(request), std::move(instance_host));
}
void StopWorker(const StopWorkerCallback& callback) override {
@@ -488,6 +489,7 @@ TEST_F(ServiceWorkerContextTest, UnregisterMultiple) {
EXPECT_EQ(REGISTRATION_STORED, notifications_[3].type);
EXPECT_EQ(origin3_p1, notifications_[3].pattern);
EXPECT_EQ(registration_id4, notifications_[3].registration_id);
+
shimazu 2017/04/06 05:01:36 Could you remote this extra line?
leonhsl(Using Gerrit) 2017/04/06 09:58:55 Done.
EXPECT_EQ(REGISTRATION_DELETED, notifications_[4].type);
EXPECT_EQ(origin1_p2, notifications_[4].pattern);
EXPECT_EQ(registration_id2, notifications_[4].registration_id);

Powered by Google App Engine
This is Rietveld 408576698