pkg/http_parser: fixed edge cases with 9s and single-digit days

pkg/http_parser/lib/src/http_date.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library http_parser;
 
 import 'package:string_scanner/string_scanner.dart';
 
 const _WEEKDAYS = const ["Mon", "Tue", "Wed", "Thu", "Fri", "Sat", "Sun"];
 const _MONTHS = const ["Jan", "Feb", "Mar", "Apr", "May", "Jun", "Jul", "Aug",
     "Sep", "Oct", "Nov", "Dec"];
 
 final _shortWeekdayRegExp = new RegExp(r"Mon|Tue|Wed|Thu|Fri|Sat|Sun");
 final _longWeekdayRegExp =
     new RegExp(r"Monday|Tuesday|Wednesday|Thursday|Friday|Saturday|Sunday");
 final _monthRegExp =
     new RegExp(r"Jan|Feb|Mar|Apr|May|Jun|Jul|Aug|Sep|Oct|Nov|Dec");
 final _digitRegExp = new RegExp(r"\d+");
 
 /// Return a HTTP-formatted string representation of [date].
 ///
 /// This follows [RFC 822](http://tools.ietf.org/html/rfc822) as updated by [RFC
 /// 1123](http://tools.ietf.org/html/rfc1123).
 String formatHttpDate(DateTime date) {
   date = date.toUtc();
   var buffer = new StringBuffer()
       ..write(_WEEKDAYS[date.weekday - 1])
       ..write(", ")
+      ..write(date.day <= 9 ? "0" : "")
       ..write(date.day.toString())
       ..write(" ")
       ..write(_MONTHS[date.month - 1])
       ..write(" ")
       ..write(date.year.toString())
-      ..write(date.hour < 9 ? " 0" : " ")
+      ..write(date.hour <= 9 ? " 0" : " ")
       ..write(date.hour.toString())
-      ..write(date.minute < 9 ? ":0" : ":")
+      ..write(date.minute <= 9 ? ":0" : ":")
       ..write(date.minute.toString())
-      ..write(date.second < 9 ? ":0" : ":")
+      ..write(date.second <= 9 ? ":0" : ":")
       ..write(date.second.toString())
       ..write(" GMT");
   return buffer.toString();

[nweiz, 2014/05/09 20:24:31]

This code came straight from dart:io, so it's probably a good idea to check to
see if it has the same issues.

[kevmoo, 2014/05/09 20:33:02]

It looks like it's okay here
https://github.com/dart-lang/bleeding_edge/blob/master/dart/sdk/lib/io/http_d...

[nweiz, 2014/05/09 20:39:35]

That's still missing a leading zero for the day, isn't it?

 }
 
 /// Parses an HTTP-formatted date into a UTC [DateTime].
 ///
 /// This follows [RFC
 /// 2616](http://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.3). It will
 /// throw a [FormatException] if [date] is invalid.
 DateTime parseHttpDate(String date) {
   try {
     var scanner = new StringScanner(date);
@@ skipping 90 matching lines @@
 DateTime _makeDateTime(int year, int month, int day, DateTime time) {
   var dateTime = new DateTime.utc(
       year, month, day, time.hour, time.minute, time.second);
 
   // If [day] was too large, it will cause [month] to overflow.
   if (dateTime.month != month) {
     throw new FormatException("invalid day '$day' for month '$month'.");
   }
   return dateTime;
 }