pkg/http_parser: fixed edge cases with 9s and single-digit days

pkg/http_parser: fixed edge cases with 9s and single-digit days

R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35992

[kevmoo, 2014-05-09 05:02:00]

Oops :-)

[nweiz, 2014-05-09 20:24:30]

lgtm

https://codereview.chromium.org/278783002/diff/1/pkg/http_parser/lib/src/http...
File pkg/http_parser/lib/src/http_date.dart (right):

https://codereview.chromium.org/278783002/diff/1/pkg/http_parser/lib/src/http...
pkg/http_parser/lib/src/http_date.dart:42: return buffer.toString();
This code came straight from dart:io, so it's probably a good idea to check to
see if it has the same issues.

[kevmoo, 2014-05-09 20:26:19]

Committed patchset #1 manually as r35992 (presubmit successful).

[kevmoo, 2014-05-09 20:33:02]

I guess we're out of sync on if the date number needs a leading zero.

https://codereview.chromium.org/278783002/diff/1/pkg/http_parser/lib/src/http...
File pkg/http_parser/lib/src/http_date.dart (right):

https://codereview.chromium.org/278783002/diff/1/pkg/http_parser/lib/src/http...
pkg/http_parser/lib/src/http_date.dart:42: return buffer.toString();
On 2014/05/09 20:24:31, nweiz wrote:
> This code came straight from dart:io, so it's probably a good idea to check to
> see if it has the same issues.

It looks like it's okay here
https://github.com/dart-lang/bleeding_edge/blob/master/dart/sdk/lib/io/http_d...

[nweiz, 2014-05-09 20:39:35]

https://codereview.chromium.org/278783002/diff/1/pkg/http_parser/lib/src/http...
File pkg/http_parser/lib/src/http_date.dart (right):

https://codereview.chromium.org/278783002/diff/1/pkg/http_parser/lib/src/http...
pkg/http_parser/lib/src/http_date.dart:42: return buffer.toString();
On 2014/05/09 20:33:02, kevmoo wrote:
> On 2014/05/09 20:24:31, nweiz wrote:
> > This code came straight from dart:io, so it's probably a good idea to check
to
> > see if it has the same issues.
> 
> It looks like it's okay here
>
https://github.com/dart-lang/bleeding_edge/blob/master/dart/sdk/lib/io/http_d...

That's still missing a leading zero for the day, isn't it?

[kevmoo, 2014-05-09 20:43:21]

On 2014/05/09 20:39:35, nweiz wrote:
>
https://codereview.chromium.org/278783002/diff/1/pkg/http_parser/lib/src/http...
> File pkg/http_parser/lib/src/http_date.dart (right):
> 
>
https://codereview.chromium.org/278783002/diff/1/pkg/http_parser/lib/src/http...
> pkg/http_parser/lib/src/http_date.dart:42: return buffer.toString();
> On 2014/05/09 20:33:02, kevmoo wrote:
> > On 2014/05/09 20:24:31, nweiz wrote:
> > > This code came straight from dart:io, so it's probably a good idea to
check
> to
> > > see if it has the same issues.
> > 
> > It looks like it's okay here
> >
>
https://github.com/dart-lang/bleeding_edge/blob/master/dart/sdk/lib/io/http_d...
> 
> That's still missing a leading zero for the day, isn't it?

Yes, but it *seems* okay

http://tools.ietf.org/html/rfc1123#page-55

date = 1*2DIGIT month 2*4DIGIT

But doing a quick survey of sites I'm on now, all of them have send me

Fri, 09 May 2014 20:42:52 GMT

...So I'll file a bug