Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3374)

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.h

Issue 278773002: Add 'Revoke File Permissions' button to App Info Dialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Small fixes Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.h
diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.h b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.h
index 3fb042b9363b6c2b6854c87b8c044c6b9ea71feb..aabb7dff7ce53ff8843adda1cbcc4f0af531f019 100644
--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.h
+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.h
@@ -7,6 +7,7 @@
#include "chrome/browser/ui/views/apps/app_info_dialog/app_info_tab.h"
#include "ui/gfx/native_widget_types.h"
+#include "ui/views/controls/button/button.h"
class Profile;
@@ -14,13 +15,17 @@ namespace extensions {
class Extension;
class PermissionSet;
}
+namespace ui {
+class Event;
+}
namespace views {
+class LabelButton;
class ScrollView;
}
// The Permissions tab of the app info dialog, which provides insight and
// control over the app's various permissions.
-class AppInfoPermissionsTab : public AppInfoTab {
+class AppInfoPermissionsTab : public AppInfoTab, views::ButtonListener {
public:
AppInfoPermissionsTab(gfx::NativeWindow parent_window,
Profile* profile,
@@ -42,6 +47,14 @@ class AppInfoPermissionsTab : public AppInfoTab {
// Overridden from views::View:
virtual void Layout() OVERRIDE;
+ // Overridden from views::ButtonListener:
+ virtual void ButtonPressed(views::Button* sender,
+ const ui::Event& event) OVERRIDE;
+
+ // Clears all retained file permissions for this app, restarts the app and
+ // closes this dialog.
+ void RevokeFilePermissions();
+
const extensions::PermissionSet* GetRequiredPermissions() const;
const std::vector<base::string16> GetRequiredPermissionMessages() const;
@@ -52,6 +65,7 @@ class AppInfoPermissionsTab : public AppInfoTab {
const std::vector<base::string16> GetRetainedFilePermissionMessages() const;
views::ScrollView* scroll_view_;
+ views::LabelButton* revoke_file_permissions_button_;
DISALLOW_COPY_AND_ASSIGN(AppInfoPermissionsTab);
};

Powered by Google App Engine
This is Rietveld 408576698