content/browser/renderer_host/media/video_capture_manager_unittest.cc - Issue 2787703004: [Mojo Video Capture] Fix VideoCaptureManager exposing implementation details to clients

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/video_capture_manager_unittest.cc

Issue 2787703004: [Mojo Video Capture] Fix VideoCaptureManager exposing implementation details to clients (Closed)

Patch Set: Pull changes from upstream Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/media/media_stream_manager.cc ('K') | « content/browser/renderer_host/media/video_capture_manager.h ('k') | content/browser/renderer_host/media/video_capture_unittest.cc » ('j') | media/capture/video/video_capture_system.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/video_capture_manager_unittest.cc

diff --git a/content/browser/renderer_host/media/video_capture_manager_unittest.cc b/content/browser/renderer_host/media/video_capture_manager_unittest.cc

index e4c9ff78e7e2849f8690548f53be732bd9eed458..064be4cf89ae683cc138a471efcb7d6d83136095 100644

--- a/content/browser/renderer_host/media/video_capture_manager_unittest.cc

+++ b/content/browser/renderer_host/media/video_capture_manager_unittest.cc

@@ -200,7 +200,7 @@ class VideoCaptureManagerTest : public testing::Test {

auto video_capture_device_factory =

base::MakeUnique<WrappedDeviceFactory>();

video_capture_device_factory_ = video_capture_device_factory.get();

- auto video_capture_system = base::MakeUnique<media::VideoCaptureSystem>(

+ auto video_capture_system = base::MakeUnique<media::VideoCaptureSystemImpl>(

std::move(video_capture_device_factory));

vcm_ = new VideoCaptureManager(std::move(video_capture_system),

base::ThreadTaskRunnerHandle::Get());