chrome/browser/extensions/process_manager_browsertest.cc - Issue 2787573003: Remove DumpWithoutCrashing from ShouldAllowOpenURL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/process_manager_browsertest.cc

Issue 2787573003: Remove DumpWithoutCrashing from ShouldAllowOpenURL. (Closed)

Patch Set: Address asvitkine's comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/process_manager_browsertest.cc

diff --git a/chrome/browser/extensions/process_manager_browsertest.cc b/chrome/browser/extensions/process_manager_browsertest.cc

index 0625ae20206b1765a04f21c84f7c1f9d87912550..adaf411010263d70ef6491d0d12833856fa99f96 100644

--- a/chrome/browser/extensions/process_manager_browsertest.cc

+++ b/chrome/browser/extensions/process_manager_browsertest.cc

@@ -1123,6 +1123,8 @@ IN_PROC_BROWSER_TEST_F(ProcessManagerBrowserTest,

0 /* FAILURE_FILE_SYSTEM_URL */, 1);

uma.ExpectBucketCount("Extensions.ShouldAllowOpenURL.Failure",

1 /* FAILURE_BLOB_URL */, 1);

+ uma.ExpectUniqueSample("Extensions.ShouldAllowOpenURL.Failure.Scheme",

+ 2 /* SCHEME_HTTP */, 2);

}

// Verify that a web popup created via window.open from an extension page can