Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: chrome/browser/PRESUBMIT.py

Issue 2787573003: Remove DumpWithoutCrashing from ShouldAllowOpenURL. (Closed)
Patch Set: Address asvitkine's comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/chrome_content_browser_client_extensions_part.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/PRESUBMIT.py
diff --git a/chrome/browser/PRESUBMIT.py b/chrome/browser/PRESUBMIT.py
index 0350a0624b30978bfd71b8b700d672338bc64f98..94c146a4c2836f1b7319302a3bf7501f025561ec 100644
--- a/chrome/browser/PRESUBMIT.py
+++ b/chrome/browser/PRESUBMIT.py
@@ -12,7 +12,6 @@ http://www.chromium.org/developers/web-development-style-guide for the rules
checked for here.
"""
-
def CheckChangeOnUpload(input_api, output_api):
return _CommonChecks(input_api, output_api)
@@ -29,9 +28,17 @@ def _RunHistogramChecks(input_api, output_api, histogram_name):
input_api.change.RepositoryRoot(),
'tools', 'metrics', 'histograms')]
+ results = []
+
import presubmit_bad_message_reasons
- return presubmit_bad_message_reasons.PrecheckBadMessage(input_api,
- output_api, histogram_name)
+ results.extend(presubmit_bad_message_reasons.PrecheckBadMessage(input_api,
+ output_api, histogram_name))
+
+ import presubmit_scheme_histograms
+ results.extend(presubmit_scheme_histograms.
+ PrecheckShouldAllowOpenURLEnums(input_api, output_api))
+
+ return results
except:
return [output_api.PresubmitError('Could not verify histogram!')]
finally:
« no previous file with comments | « no previous file | chrome/browser/extensions/chrome_content_browser_client_extensions_part.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698