Remove DumpWithoutCrashing from ShouldAllowOpenURL.

chrome/browser/extensions/chrome_content_browser_client_extensions_part.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_CHROME_CONTENT_BROWSER_CLIENT_EXTENSIONS_PART_H_
 #define CHROME_BROWSER_EXTENSIONS_CHROME_CONTENT_BROWSER_CLIENT_EXTENSIONS_PART_H_
 
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "chrome/browser/chrome_content_browser_client_parts.h"
@@ skipping 54 matching lines @@
 
   // Helper function to call InfoMap::SetSigninProcess().
   static void SetSigninProcess(content::SiteInstance* site_instance);
 
   // Creates a new VpnServiceProxy. The caller owns the returned value. It's
   // valid to return nullptr.
   static std::unique_ptr<content::VpnServiceProxy> GetVpnServiceProxy(
       content::BrowserContext* browser_context);
 
  private:
+  FRIEND_TEST_ALL_PREFIXES(ChromeContentBrowserClientExtensionsPartTest,
+                           ShouldAllowOpenURLMetricsForEmptySiteURL);
+  FRIEND_TEST_ALL_PREFIXES(ChromeContentBrowserClientExtensionsPartTest,
+                           ShouldAllowOpenURLMetricsForKnownSchemes);
+
+  // Specifies reasons why web-accessible resource checks in ShouldAllowOpenURL
+  // might fail.
+  //
+  // This enum backs an UMA histogram.  The order of existing values
+  // should not be changed, and new values should only be added before
+  // FAILURE_LAST.
+  enum ShouldAllowOpenURLFailureReason {
+    FAILURE_FILE_SYSTEM_URL = 0,
+    FAILURE_BLOB_URL,
+    FAILURE_SCHEME_NOT_HTTP_OR_HTTPS_OR_EXTENSION,
+    FAILURE_RESOURCE_NOT_WEB_ACCESSIBLE,
+    FAILURE_LAST,
+  };
+
+  // Records metrics when ShouldAllowOpenURL blocks a load.  |site_url|
+  // corresponds to the SiteInstance that initiated the blocked load.
+  static void RecordShouldAllowOpenURLFailure(
+      ShouldAllowOpenURLFailureReason reason,
+      GURL site_url);

[Devlin, 2017/04/05 01:11:57]

const &

[alexmos, 2017/04/05 17:24:51]

Done.

+
   // ChromeContentBrowserClientParts:
   void RenderProcessWillLaunch(content::RenderProcessHost* host) override;
   void SiteInstanceGotProcess(content::SiteInstance* site_instance) override;
   void SiteInstanceDeleting(content::SiteInstance* site_instance) override;
   void OverrideWebkitPrefs(content::RenderViewHost* rvh,
                            content::WebPreferences* web_prefs) override;
   void BrowserURLHandlerCreated(content::BrowserURLHandler* handler) override;
   void GetAdditionalAllowedSchemesForFileSystem(
       std::vector<std::string>* additional_allowed_schemes) override;
   void GetURLRequestAutoMountHandlers(
       std::vector<storage::URLRequestAutoMountHandler>* handlers) override;
   void GetAdditionalFileSystemBackends(
       content::BrowserContext* browser_context,
       const base::FilePath& storage_partition_path,
       std::vector<std::unique_ptr<storage::FileSystemBackend>>*
           additional_backends) override;
   void AppendExtraRendererCommandLineSwitches(
       base::CommandLine* command_line,
       content::RenderProcessHost* process,
       Profile* profile) override;
   void ResourceDispatcherHostCreated() override;
 
   DISALLOW_COPY_AND_ASSIGN(ChromeContentBrowserClientExtensionsPart);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_CHROME_CONTENT_BROWSER_CLIENT_EXTENSIONS_PART_H_