Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 278753002: Use sane default screen size if RANDR not supported (Closed)

Created:
6 years, 7 months ago by Lambros
Modified:
6 years, 7 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Visibility:
Public.

Description

Use sane default screen size if RANDR not supported In order of precedence, set size according to: * Command line parameters if present * Environment variable if present * 1600x1200,3840x1600 if RANDR is present, otherwise just 1600x1200. R=jamiewalch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269476

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -12 lines) Patch
M remoting/host/linux/linux_me2me_host.py View 5 chunks +32 lines, -12 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Lambros
6 years, 7 months ago (2014-05-09 03:20:57 UTC) #1
Jamie
LGTM with nit. https://codereview.chromium.org/278753002/diff/1/remoting/host/linux/linux_me2me_host.py File remoting/host/linux/linux_me2me_host.py (right): https://codereview.chromium.org/278753002/diff/1/remoting/host/linux/linux_me2me_host.py#newcode1037 remoting/host/linux/linux_me2me_host.py:1037: if get_randr_supporting_x_server(): Can you just use ...
6 years, 7 months ago (2014-05-09 16:41:28 UTC) #2
Lambros
https://codereview.chromium.org/278753002/diff/1/remoting/host/linux/linux_me2me_host.py File remoting/host/linux/linux_me2me_host.py (right): https://codereview.chromium.org/278753002/diff/1/remoting/host/linux/linux_me2me_host.py#newcode1037 remoting/host/linux/linux_me2me_host.py:1037: if get_randr_supporting_x_server(): On 2014/05/09 16:41:28, Jamie wrote: > Can ...
6 years, 7 months ago (2014-05-09 19:50:01 UTC) #3
Lambros
6 years, 7 months ago (2014-05-10 01:52:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r269476 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698