Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2787513003: Expose function contained in GenericTypeAliasImpl. (Closed)

Created:
3 years, 8 months ago by jcollins
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add disclaimer to Generic classes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M pkg/analyzer/lib/dart/element/element.dart View 1 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jcollins
On 2017/03/29 16:52:14, jcollins wrote: > mailto:jcollins@google.com changed reviewers: > + mailto:brianwilkerson@google.com ping
3 years, 8 months ago (2017-03-30 14:37:40 UTC) #3
jcollins
On 2017/03/29 16:52:14, jcollins wrote: > mailto:jcollins@google.com changed reviewers: > + mailto:brianwilkerson@google.com ping
3 years, 8 months ago (2017-03-30 14:37:42 UTC) #4
Brian Wilkerson
lgtm Don't forget to create a cherry-pick request for this CL. https://codereview.chromium.org/2787513003/diff/1/pkg/analyzer/lib/dart/element/element.dart File pkg/analyzer/lib/dart/element/element.dart (right): ...
3 years, 8 months ago (2017-03-30 14:43:50 UTC) #5
jcollins
https://codereview.chromium.org/2787513003/diff/1/pkg/analyzer/lib/dart/element/element.dart File pkg/analyzer/lib/dart/element/element.dart (right): https://codereview.chromium.org/2787513003/diff/1/pkg/analyzer/lib/dart/element/element.dart#newcode1338 pkg/analyzer/lib/dart/element/element.dart:1338: */ On 2017/03/30 14:43:50, Brian Wilkerson wrote: > Please ...
3 years, 8 months ago (2017-03-30 15:19:35 UTC) #6
jcollins
3 years, 8 months ago (2017-03-30 16:08:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
37330be1b9b631baa3d426c9484d5e9714ad1a9b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698