ios/chrome/browser/ui/favicon/favicon_attributes_provider.mm - Issue 2787503002: Move FaviconAttributes to UI

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/ui/favicon/favicon_attributes_provider.mm

Issue 2787503002: Move FaviconAttributes to UI (Closed)

Patch Set: Add blank line Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ios/chrome/browser/ui/favicon/favicon_attributes_provider.h ('k') | ios/chrome/browser/ui/favicon/favicon_view.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #import "ios/chrome/browser/favicon/favicon_attributes_provider.h"	5 #import "ios/chrome/browser/ui/favicon/favicon_attributes_provider.h"

6	6

7 #include "base/logging.h"	7 #include "base/logging.h"

8 #include "base/mac/bind_objc_block.h"	8 #include "base/mac/bind_objc_block.h"

9 #include "base/strings/sys_string_conversions.h"	9 #include "base/strings/sys_string_conversions.h"

10 #include "base/strings/utf_string_conversions.h"	10 #include "base/strings/utf_string_conversions.h"

11 #include "base/task/cancelable_task_tracker.h"	11 #include "base/task/cancelable_task_tracker.h"

12 #include "components/favicon/core/fallback_url_util.h"	12 #include "components/favicon/core/fallback_url_util.h"

13 #include "components/favicon/core/large_icon_service.h"	13 #include "components/favicon/core/large_icon_service.h"

14 #include "components/favicon_base/fallback_icon_style.h"	14 #include "components/favicon_base/fallback_icon_style.h"

15 #include "components/favicon_base/favicon_types.h"	15 #include "components/favicon_base/favicon_types.h"

(...skipping 61 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
77 };	77 };

78	78

79 // Always call LargeIconService in case the favicon was updated.	79 // Always call LargeIconService in case the favicon was updated.

80 CGFloat faviconSize = [UIScreen mainScreen].scale * self.faviconSize;	80 CGFloat faviconSize = [UIScreen mainScreen].scale * self.faviconSize;

81 CGFloat minFaviconSize = [UIScreen mainScreen].scale * self.minSize;	81 CGFloat minFaviconSize = [UIScreen mainScreen].scale * self.minSize;

82 self.largeIconService->GetLargeIconOrFallbackStyle(	82 self.largeIconService->GetLargeIconOrFallbackStyle(

83 URL, minFaviconSize, faviconSize, base::BindBlockArc(faviconBlock),	83 URL, minFaviconSize, faviconSize, base::BindBlockArc(faviconBlock),

84 &_faviconTaskTracker);	84 &_faviconTaskTracker);

85 }	85 }

86 @end	86 @end

OLD	NEW