Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 27873002: Reapply/merge derived_sources.gyp useless use of cat (demoggification) (Closed)

Created:
7 years, 2 months ago by Nils Barth (inactive)
Modified:
7 years, 2 months ago
Reviewers:
haraken, Nico
CC:
blink-reviews, kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive, kihong, kouhei (in TOK)
Visibility:
Public.

Description

Reapply/merge derived_sources.gyp useless use of cat (demoggification) This replaces 2 instances in GYP of <!(cat <(foo_files_list)) with: <@(files_list) ...avoiding indirection and a shell out to cat. Nico's 1-line CL: Make code slightly less complicated https://codereview.chromium.org/26980003/ ...was clobbered by Kihong's large, long-running CL: Support partial interface for test support idls https://codereview.chromium.org/24053003/ Nico noted this in comment: https://codereview.chromium.org/24053003/#msg50 This CL cleans up and merges Nico's prior demoggification. http://en.wikipedia.org/wiki/Useless_use_of_cat Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159971

Patch Set 1 #

Patch Set 2 : Fix typo #

Patch Set 3 : Fix typo #

Patch Set 4 : Reupload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/bindings/derived_sources.gyp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Nils Barth (inactive)
Hi Nico, fixed per comment. (haraken: simple GYP cleanup that got clobbered by a separate ...
7 years, 2 months ago (2013-10-18 00:56:48 UTC) #1
haraken
LGTM
7 years, 2 months ago (2013-10-18 01:00:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/27873002/1
7 years, 2 months ago (2013-10-18 01:02:53 UTC) #3
Nico
Hi, I'm not sure if my comment is correct since rietveld doesn't show the side-by-side ...
7 years, 2 months ago (2013-10-18 01:10:58 UTC) #4
Nico
(thanks for taking this on btw!)
7 years, 2 months ago (2013-10-18 01:11:07 UTC) #5
Nils Barth (inactive)
On 2013/10/18 01:10:58, Nico wrote: > Hi, > > I'm not sure if my comment ...
7 years, 2 months ago (2013-10-18 01:18:06 UTC) #6
Nico
lgtm Thank you!
7 years, 2 months ago (2013-10-18 01:22:03 UTC) #7
Nils Barth (inactive)
On 2013/10/18 01:22:03, Nico wrote: > lgtm > > Thank you! n/p! (Just gotta wait ...
7 years, 2 months ago (2013-10-18 01:22:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/27873002/145001
7 years, 2 months ago (2013-10-18 02:41:46 UTC) #9
commit-bot: I haz the power
7 years, 2 months ago (2013-10-18 23:20:30 UTC) #10
Message was sent while issue was closed.
Change committed as 159971

Powered by Google App Engine
This is Rietveld 408576698