Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: chromeos/dbus/services/proxy_resolution_service_provider.h

Issue 2787253002: chromeos: Simplify D-Bus proxy provider (but not tests). (Closed)
Patch Set: remove error stuff from tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/services/proxy_resolution_service_provider.h
diff --git a/chromeos/dbus/services/proxy_resolution_service_provider.h b/chromeos/dbus/services/proxy_resolution_service_provider.h
index 6cac9fa1e2a5fbdce30c036819c4daf42893fa5c..244994d347e16ca3aa76f796a1f8b3d514cb0d81 100644
--- a/chromeos/dbus/services/proxy_resolution_service_provider.h
+++ b/chromeos/dbus/services/proxy_resolution_service_provider.h
@@ -16,8 +16,6 @@
#include "dbus/exported_object.h"
#include "net/base/completion_callback.h"
-class GURL;
-
namespace base {
class SingleThreadTaskRunner;
}
@@ -27,8 +25,6 @@ class MethodCall;
}
namespace net {
-class ProxyInfo;
-class ProxyService;
class URLRequestContextGetter;
}
@@ -82,13 +78,6 @@ class CHROMEOS_EXPORT ProxyResolutionServiceProvider
// Returns the request context used to perform proxy resolution.
// Always called on UI thread.
virtual scoped_refptr<net::URLRequestContextGetter> GetRequestContext() = 0;
-
- // Thin wrapper around net::ProxyService::ResolveProxy() to make testing
- // easier.
- virtual int ResolveProxy(net::ProxyService* proxy_service,
- const GURL& url,
- net::ProxyInfo* results,
- const net::CompletionCallback& callback) = 0;
};
explicit ProxyResolutionServiceProvider(std::unique_ptr<Delegate> delegate);

Powered by Google App Engine
This is Rietveld 408576698