Issue 2787123007: Do the obvious thing for first-line styles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2787123007: Do the obvious thing for first-line styles.

Created:
3 years, 8 months ago by emilio

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, sof, eae+blinkwatch, leviw+renderwatch, blink-reviews-dom_chromium.org, dglazkov+blink, jchaffraix+rendering, blink-reviews, rwlbuis

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Do the obvious thing for first-line styles. I'm not sure what's all this complexity about TBH. This fixes issue 706316, but I'm almost sure this patch will break something. BUG=706316

Patch Set 1 #

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -98 lines)			Patch
	M	third_party/WebKit/Source/core/dom/Document.cpp	View		2 chunks	+31 lines, -63 lines	0 comments	Download
	M	third_party/WebKit/Source/core/layout/LayoutObject.cpp	View		2 chunks	+6 lines, -35 lines	0 comments	Download

Messages

Total messages: 4 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

emilio

The CQ bit was checked by ecobos@igalia.com to run a CQ dry run

3 years, 8 months ago (2017-04-02 00:12:09 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2787123007/1

3 years, 8 months ago (2017-04-02 00:12:19 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 8 months ago (2017-04-02 01:56:40 UTC) #3

commit-bot: I haz the power

3 years, 8 months ago (2017-04-02 01:56:41 UTC) #4

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages