Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(939)

Unified Diff: content/public/test/render_view_test.cc

Issue 2787123005: Block data URL navigations with RenderFrameImpl::DecidePolicyForNavigation (Closed)
Patch Set: Attempt another fix Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/common/content_features.cc ('k') | content/public/test/test_navigation_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/render_view_test.cc
diff --git a/content/public/test/render_view_test.cc b/content/public/test/render_view_test.cc
index f2d07e4be50fde15003197c0e000a566f18b99b4..432b3baf58df6ac8d54e7d36deba03af86d35f59 100644
--- a/content/public/test/render_view_test.cc
+++ b/content/public/test/render_view_test.cc
@@ -188,14 +188,7 @@ bool RenderViewTest::ExecuteJavaScriptAndReturnIntValue(
void RenderViewTest::LoadHTML(const char* html) {
std::string url_string = "data:text/html;charset=utf-8,";
url_string.append(html);
- GURL url(url_string);
- WebURLRequest request(url);
- request.SetCheckForBrowserSideNavigation(false);
- GetMainFrame()->LoadRequest(request);
- // The load actually happens asynchronously, so we pump messages to process
- // the pending continuation.
- FrameLoadWaiter(view_->GetMainRenderFrame()).Wait();
- view_->GetWebView()->UpdateAllLifecyclePhases();
+ LoadHTMLWithUrlOverride(html, url_string.c_str());
}
void RenderViewTest::LoadHTMLWithUrlOverride(const char* html,
« no previous file with comments | « content/public/common/content_features.cc ('k') | content/public/test/test_navigation_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698