Fetch API: Stop lowercasing header names.

third_party/WebKit/Source/modules/cachestorage/Cache.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/cachestorage/Cache.h"
 
 #include "bindings/core/v8/CallbackPromiseAdapter.h"
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "bindings/core/v8/ScriptState.h"
@@ skipping 187 matching lines @@
   }
   DEFINE_THREAD_SAFE_STATIC_LOCAL(
       EnumerationHistogram, responseTypeHistogram,
       new EnumerationHistogram("ServiceWorkerCache.Cache.AddResponseType",
                                static_cast<int>(ResponseType::EnumMax)));
   responseTypeHistogram.count(static_cast<int>(type));
 };
 
 bool varyHeaderContainsAsterisk(const Response* response) {
   const FetchHeaderList* headers = response->headers()->headerList();
-  for (size_t i = 0; i < headers->size(); ++i) {
-    const FetchHeaderList::Header& header = headers->entry(i);
-    if (header.first == "vary") {
+  for (const auto& header : headers->list()) {
+    if (equalIgnoringCase(header.first, "vary")) {

[haraken, 2017/03/31 00:06:28]

Should we probably use equalIgnoringASCIICase instead?

[Raphael Kubo da Costa (rakuco), 2017/03/31 10:22:21]

Sure. I've done that in patch v3.

This actually reminds me if the new implementation of
FetchHeaderList::sortAndCombine() looks OK: there's no WTFString::lowerASCII(),
so I end up calling WTFString::lower() even though the spec says the header
names should only be "byte-lowercased".

       Vector<String> fields;
       header.second.split(',', fields);
       for (size_t j = 0; j < fields.size(); ++j) {
         if (fields[j].stripWhiteSpace() == "*")
           return true;
       }
     }
   }
   return false;
 }
@@ skipping 478 matching lines @@
       WTF::makeUnique<CacheWithRequestsCallbacks>(resolver), webRequest,
       toWebQueryParams(options));
   return promise;
 }
 
 WebServiceWorkerCache* Cache::webCache() const {
   return m_webCache.get();
 }
 
 }  // namespace blink