Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl

Issue 2786883002: Generate subgroup StyleSurroundData in ComputedStyle. (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {% macro encode(field, value) %} 1 {% macro encode(field, value) %}
2 {% if field.is_bit_field -%} 2 {% if field.is_bit_field -%}
3 static_cast<unsigned>({{value}}) 3 static_cast<unsigned>({{value}})
4 {%- else -%} 4 {%- else -%}
5 {{value}} 5 {{value}}
6 {%- endif %} 6 {%- endif %}
7 {% endmacro %} 7 {% endmacro %}
8 8
9 {% macro decode(field, value) %} 9 {% macro decode(field, value) %}
10 {% if field.is_bit_field -%} 10 {% if field.is_bit_field -%}
11 static_cast<{{field.type_name}}>({{value}}) 11 static_cast<{{field.type_name}}>({{value}})
12 {%- else -%} 12 {%- else -%}
13 {{value}} 13 {{value}}
14 {%- endif %} 14 {%- endif %}
15 {% endmacro %} 15 {% endmacro %}
16 16
17 {% macro get_expr(field) %}
meade_UTC10 2017/04/06 03:29:57 Can we name this better (and use full words)? e.g.
shend 2017/04/06 04:39:40 For these macros, should the naming be treated as
meade_UTC10 2017/04/20 03:08:40 I don't have strong opinions, other than consisten
shend 2017/04/20 03:22:34 Ok, I did getter_expression(field), since field.ge
18 {% if field.field_group -%}
19 m_{{field.field_group}}->{{field.name}}
20 {%- else -%}
21 {{field.name}}
22 {%- endif %}
23 {% endmacro %}
24
25 {% macro set_expr(field) %}
meade_UTC10 2017/04/06 03:29:57 ditto
shend 2017/04/20 03:22:34 Done.
26 {% if field.field_group -%}
27 m_{{field.field_group}}.access()->{{field.name}}
28 {%- else -%}
29 {{field.name}}
30 {%- endif %}
31 {% endmacro %}
32
17 {% macro return_type(field) %} 33 {% macro return_type(field) %}
18 {% if field.is_bit_field -%} 34 {% if field.is_bit_field -%}
19 {{field.type_name}} 35 {{field.type_name}}
20 {%- else -%} 36 {%- else -%}
21 const {{field.type_name}}& 37 const {{field.type_name}}&
22 {%- endif %} 38 {%- endif %}
23 {% endmacro %} 39 {% endmacro %}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698