Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Unified Diff: third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h

Issue 2786853002: Let RangeBoundaryPoint::toPoisition return Position not considering Editing (Closed)
Patch Set: update Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h
diff --git a/third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h b/third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h
index 32d2681fea6b9042c17366bdf35f5b4a1d17d74b..c4aead765ab63dc820710103d405f60df266fac4 100644
--- a/third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h
+++ b/third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h
@@ -129,10 +129,7 @@ inline bool RangeBoundaryPoint::isOffsetValid() const {
inline const Position RangeBoundaryPoint::toPosition() const {
ensureOffsetIsValid();
- // TODO(yosin): We should return |Position::beforeAnchor| when
yosin_UTC9 2017/03/30 05:44:58 Could you keep this TODO? We still want to return
yoichio 2017/03/30 07:04:09 Could you explain why ?
- // |m_containerNode| isn't |Text| node.
- return Position::editingPositionOf(m_containerNode.get(),
- m_offsetInContainer);
+ return Position(m_containerNode.get(), m_offsetInContainer);
}
inline unsigned RangeBoundaryPoint::offset() const {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698