Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Unified Diff: build/android/pylib/instrumentation/instrumentation_test_instance.py

Issue 2786773002: (Reland) Add failure screenshots and images to results detail. (Closed)
Patch Set: (Reland) Add failure screenshots and images to results detail. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/instrumentation/instrumentation_test_instance.py
diff --git a/build/android/pylib/instrumentation/instrumentation_test_instance.py b/build/android/pylib/instrumentation/instrumentation_test_instance.py
index 5261ff284b3c76c78404200be2a3bfff35074f25..787b4e082b10f8b67373674714e2e30563fa9ffe 100644
--- a/build/android/pylib/instrumentation/instrumentation_test_instance.py
+++ b/build/android/pylib/instrumentation/instrumentation_test_instance.py
@@ -498,6 +498,7 @@ class InstrumentationTestInstance(test_instance.TestInstance):
self._store_tombstones = False
self._initializeTombstonesAttributes(args)
+ self._should_save_images = None
self._should_save_logcat = None
self._initializeLogAttributes(args)
@@ -683,6 +684,7 @@ class InstrumentationTestInstance(test_instance.TestInstance):
def _initializeLogAttributes(self, args):
self._should_save_logcat = bool(args.json_results_file)
+ self._should_save_images = bool(args.json_results_file)
jbudorick 2017/04/11 00:36:43 nit: alpha
mikecase (-- gone --) 2017/04/26 18:01:51 done
def _initializeEditPrefsAttributes(self, args):
if not hasattr(args, 'shared_prefs_file'):
@@ -747,6 +749,10 @@ class InstrumentationTestInstance(test_instance.TestInstance):
return self._flags
@property
+ def should_save_images(self):
+ return self._should_save_images
+
+ @property
def should_save_logcat(self):
return self._should_save_logcat

Powered by Google App Engine
This is Rietveld 408576698