Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Unified Diff: build/android/pylib/instrumentation/instrumentation_test_instance.py

Issue 2786773002: (Reland) Add failure screenshots and images to results detail. (Closed)
Patch Set: yolands nit Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/pylib/local/device/local_device_instrumentation_test_run.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/instrumentation/instrumentation_test_instance.py
diff --git a/build/android/pylib/instrumentation/instrumentation_test_instance.py b/build/android/pylib/instrumentation/instrumentation_test_instance.py
index d8f0995269327ff03c4407424f3b5c37fb86d0a1..2324fca1194d3efc8ad608b40abd5fc68e5ce898 100644
--- a/build/android/pylib/instrumentation/instrumentation_test_instance.py
+++ b/build/android/pylib/instrumentation/instrumentation_test_instance.py
@@ -498,6 +498,7 @@ class InstrumentationTestInstance(test_instance.TestInstance):
self._store_tombstones = False
self._initializeTombstonesAttributes(args)
+ self._gs_results_bucket = None
self._should_save_logcat = None
self._initializeLogAttributes(args)
@@ -682,6 +683,7 @@ class InstrumentationTestInstance(test_instance.TestInstance):
self._store_tombstones = args.store_tombstones
def _initializeLogAttributes(self, args):
+ self._gs_results_bucket = args.gs_results_bucket
self._should_save_logcat = bool(args.json_results_file)
def _initializeEditPrefsAttributes(self, args):
@@ -747,6 +749,10 @@ class InstrumentationTestInstance(test_instance.TestInstance):
return self._flags
@property
+ def gs_results_bucket(self):
+ return self._gs_results_bucket
+
+ @property
def should_save_logcat(self):
return self._should_save_logcat
« no previous file with comments | « no previous file | build/android/pylib/local/device/local_device_instrumentation_test_run.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698