(Reland) Add failure screenshots and images to results detail.

build/android/pylib/utils/google_storage_helper.py

+# Copyright 2017 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Helper functions to upload data to Google Storage.
+
+Text data should be streamed to logdog using |logdog_helper| module.
+Due to logdog not having image or HTML viewer, those instead should be uploaded
+to Google Storage directly using this module.
+"""
+
+import logging
+import os
+import sys
+import time
+
+from pylib.constants import host_paths
+from pylib.utils import decorators
+
+if host_paths.DEVIL_PATH not in sys.path:
+  sys.path.append(host_paths.DEVIL_PATH)
+from devil.utils import cmd_helper
+
+_GSUTIL_PATH = os.path.join(
+    host_paths.DIR_SOURCE_ROOT, 'third_party', 'catapult',
+    'third_party', 'gsutil', 'gsutil.py')
+_PUBLIC_URL = 'https://storage.googleapis.com/%s/'
+_AUTHENICATED_URL = 'https://storage.cloud.google.com/%s/'

[the real yoland, 2017/05/03 22:23:38]

super nit: similar as below

+
+
+@decorators.NoRaiseException(default_return_value='')
+def upload(name, filepath, bucket, content_type=None, authenticated_link=True):

[the real yoland, 2017/05/03 22:23:39]

super nit: maybe link_to_authenticate? authenticated_link sounds like a link
that requires no further authentication

[mikecase (-- gone --), 2017/05/03 22:45:18]

Ack. I think authenticated_link is still less awkward/confusing since
link_to_authenticate makes it sound like its a new, separate link just to
authenticate. When really its just a link that requires you to sign into Google
account.

+  """Uploads data to Google Storage.
+
+  Args:
+    name: Name of the file on Google Storage.
+    filepath: Path to file you want to upload.
+    bucket: Bucket to upload file to.
+    content_type: Content type to upload as. If not specified, Google storage
+        will attempt to infer content type from file extension.
+    authenticated_link: Whether to return a link that requires user to
+        authenticate with a Google account. Setting this to false will only
+        work when uploading to public storage buckets.

[the real yoland, 2017/05/03 22:23:38]

nit: as you mentioned, we might want to always use link_to_authenticate. Maybe
add a comment here

[mikecase (-- gone --), 2017/05/03 22:45:18]

Improved comment. And have default for authenticated_link=True

+  Returns:
+    Web link to item uploaded to Google Storage bucket.
+  """
+  if bucket.startswith('gs://'):
+    bucket = bucket[len('gs://'):]
+  if bucket.endswith('/'):
+    bucket = bucket[:-1]
+
+  gs_path = 'gs://%s/%s' % (bucket, name)
+  logging.info('Uploading %s to %s', filepath, gs_path)
+
+  cmd = [_GSUTIL_PATH]
+  if content_type:
+    cmd.extend(['-h', 'Content-Type:%s' % content_type])
+  cmd.extend(['cp', filepath, gs_path])
+
+  cmd_helper.RunCmd(cmd)
+
+  url_template = _AUTHENICATED_URL if authenticated_link else _PUBLIC_URL
+  return os.path.join(url_template % bucket, name)
+
+
+def unique_name(basename, suffix='', timestamp=True, device=None):
+  """Helper function for creating a unique name for a file to store in GS.
+
+  Args:
+    basename: Base of the unique filename.
+    suffix: Suffix of filename.
+    timestamp: Whether or not to add a timestamp to name.
+    device: Device to add device serial of to name.
+  """
+  return '%s%s%s%s' % (
+      basename,
+      '_%s' % time.strftime('%Y_%m_%d_T%H_%M_%S', time.localtime())

[the real yoland, 2017/05/03 22:23:38]

hmm, should this use UTC time?

[mikecase (-- gone --), 2017/05/03 22:45:18]

probably! Done

+          if timestamp else '',
+      '_%s' % device.serial if device else '',
+      suffix)