Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.h

Issue 2786673002: Separate ContentSettingsClient out from LocalFrameClient (Closed)
Patch Set: added class-level comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.h
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.h b/third_party/WebKit/Source/web/WebLocalFrameImpl.h
index 2ec2c5c780e3980487d48ec00d7eb6d6a916a066..06167122d3cb9a07ea20e5af9469a77a211ba2b1 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.h
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.h
@@ -32,6 +32,7 @@
#define WebLocalFrameImpl_h
#include "core/editing/VisiblePosition.h"
+#include "core/frame/ContentSettingsClient.h"
#include "core/frame/LocalFrame.h"
#include "platform/geometry/FloatRect.h"
#include "platform/heap/SelfKeepAlive.h"
@@ -93,7 +94,6 @@ class WEB_EXPORT WebLocalFrameImpl final
WebString assignedName() const override;
void setName(const WebString&) override;
WebVector<WebIconURL> iconURLs(int iconTypesMask) const override;
- void setContentSettingsClient(WebContentSettingsClient*) override;
void setSharedWorkerRepositoryClient(
WebSharedWorkerRepositoryClient*) override;
WebSize getScrollOffset() const override;
@@ -184,6 +184,7 @@ class WEB_EXPORT WebLocalFrameImpl final
bool isSpellCheckingEnabled() const override;
void replaceMisspelledRange(const WebString&) override;
void removeSpellingMarkers() override;
+ void setContentSettingsClient(WebContentSettingsClient*) override;
bool hasSelection() const override;
WebRange selectionRange() const override;
WebString selectionAsText() const override;
@@ -391,9 +392,10 @@ class WEB_EXPORT WebLocalFrameImpl final
WebFrameClient* client() const { return m_client; }
void setClient(WebFrameClient* client) { m_client = client; }
- WebContentSettingsClient* contentSettingsClient() {
+ ContentSettingsClient& contentSettingsClient() {
return m_contentSettingsClient;
}
+
SharedWorkerRepositoryClientImpl* sharedWorkerRepositoryClient() const {
return m_sharedWorkerRepositoryClient.get();
}
@@ -475,7 +477,7 @@ class WEB_EXPORT WebLocalFrameImpl final
WebFrameClient* m_client;
WebAutofillClient* m_autofillClient;
- WebContentSettingsClient* m_contentSettingsClient;
+ ContentSettingsClient m_contentSettingsClient;
std::unique_ptr<SharedWorkerRepositoryClientImpl>
m_sharedWorkerRepositoryClient;
« no previous file with comments | « third_party/WebKit/Source/web/StorageClientImpl.cpp ('k') | third_party/WebKit/Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698