Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.cpp

Issue 2786673002: Separate ContentSettingsClient out from LocalFrameClient (Closed)
Patch Set: added class-level comment Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/FrameLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.cpp b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
index 53f7684b8db3ea884fdd141dbc5b29bc0ca880a9..6a60f47540769500a2559c0b70066f7088f5a45e 100644
--- a/third_party/WebKit/Source/core/loader/FrameLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
@@ -50,6 +50,7 @@
#include "core/events/KeyboardEvent.h"
#include "core/events/MouseEvent.h"
#include "core/events/PageTransitionEvent.h"
+#include "core/frame/ContentSettingsClient.h"
#include "core/frame/FrameView.h"
#include "core/frame/LocalDOMWindow.h"
#include "core/frame/LocalFrame.h"
@@ -555,10 +556,10 @@ bool FrameLoader::allowPlugins(ReasonForCallingAllowPlugins reason) {
if (!client())
return false;
Settings* settings = m_frame->settings();
- bool allowed =
- client()->allowPlugins(settings && settings->getPluginsEnabled());
+ bool allowed = m_frame->contentSettingsClient()->allowPlugins(
+ settings && settings->getPluginsEnabled());
if (!allowed && reason == AboutToInstantiatePlugin)
- client()->didNotAllowPlugins();
+ m_frame->contentSettingsClient()->didNotAllowPlugins();
return allowed;
}

Powered by Google App Engine
This is Rietveld 408576698