third_party/WebKit/Source/core/html/HTMLMediaElement.cpp - Issue 2786673002: Separate ContentSettingsClient out from LocalFrameClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 2786673002: Separate ContentSettingsClient out from LocalFrameClient (Closed)

Patch Set: added class-level comment Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

index aba444552a10ad8c40c4d51f4bace25aa00ea1fd..98f325a78b1d79199829f04ffac333326d461718 100644

--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

@@ -43,6 +43,7 @@

#include "core/dom/TaskRunnerHelper.h"

#include "core/dom/shadow/ShadowRoot.h"

#include "core/events/Event.h"

+#include "core/frame/ContentSettingsClient.h"

#include "core/frame/FrameView.h"

#include "core/frame/LocalFrame.h"

#include "core/frame/LocalFrameClient.h"

@@ -3938,8 +3939,7 @@ bool HTMLMediaElement::isAutoplayAllowedPerSettings() const {

LocalFrame* frame = document().frame();

if (!frame)

return false;

- LocalFrameClient* localFrameClient = frame->loader().client();

- return localFrameClient && localFrameClient->allowAutoplay(true);

+ return frame->contentSettingsClient()->allowAutoplay(true);

}

void HTMLMediaElement::setNetworkState(NetworkState state) {