third_party/WebKit/Source/web/WebViewImpl.cpp - Issue 2786673002: Separate ContentSettingsClient out from LocalFrameClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2786673002: Separate ContentSettingsClient out from LocalFrameClient (Closed)

Patch Set: dchecks Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/web/WebLocalFrameImpl.h ('K') | « third_party/WebKit/Source/web/WebLocalFrameImpl.cpp ('k') | third_party/WebKit/public/BUILD.gn » ('j') | third_party/WebKit/public/platform/WebContentSettingsClient.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/WebViewImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp

index 6921fb01f9e7f196dbfc6c3b03646d2d3247fa0c..f13a25b1f7455395cd787bbe16487fd59e866a6a 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.cpp

+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp

@@ -34,6 +34,7 @@

#include "core/CSSValueKeywords.h"

#include "core/HTMLNames.h"

#include "core/clipboard/DataObject.h"

+#include "core/dom/ContextFeaturesClientImpl.h"

#include "core/dom/Document.h"

#include "core/dom/DocumentUserGestureToken.h"

#include "core/dom/Fullscreen.h"

@@ -90,6 +91,7 @@

#include "modules/credentialmanager/CredentialManagerClient.h"

#include "modules/encryptedmedia/MediaKeysController.h"

#include "modules/storage/StorageNamespaceController.h"

+#include "modules/webdatabase/DatabaseClient.h"

#include "modules/webgl/WebGLRenderingContext.h"

#include "platform/ContextMenu.h"

#include "platform/ContextMenuItem.h"

@@ -151,9 +153,7 @@

#include "web/CompositionUnderlineVectorBuilder.h"

#include "web/CompositorMutatorImpl.h"

#include "web/CompositorWorkerProxyClientImpl.h"

-#include "web/ContextFeaturesClientImpl.h"

#include "web/ContextMenuAllowedScope.h"

-#include "web/DatabaseClientImpl.h"

#include "web/DedicatedWorkerMessagingProxyProviderImpl.h"

#include "web/DevToolsEmulator.h"

#include "web/FullscreenController.h"

@@ -401,7 +401,7 @@ WebViewImpl::WebViewImpl(WebViewClient* client,

*m_page, SpeechRecognitionClientProxy::create(

client ? client->speechRecognizer() : nullptr));

provideContextFeaturesTo(*m_page, ContextFeaturesClientImpl::create());

- provideDatabaseClientTo(*m_page, DatabaseClientImpl::create());

+ provideDatabaseClientTo(*m_page, new DatabaseClient);

provideStorageQuotaClientTo(*m_page, StorageQuotaClientImpl::create());

m_page->setValidationMessageClient(