Separate ContentSettingsClient out from LocalFrameClient

third_party/WebKit/Source/core/loader/EmptyClients.cpp

 /*
  * Copyright (C) 2006 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2008, 2009, 2012 Apple Inc. All rights reserved.
  * Copyright (C) Research In Motion Limited 2011. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 10 matching lines @@
  * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
  * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
  * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "core/loader/EmptyClients.h"
 
 #include <memory>
+#include "core/frame/ContentSettingsClient.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/VisualViewport.h"
 #include "core/html/HTMLFormElement.h"
 #include "core/html/forms/ColorChooser.h"
 #include "core/html/forms/DateTimeChooser.h"
 #include "core/loader/DocumentLoader.h"
 #include "platform/FileChooser.h"
 #include "platform/FrameViewBase.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebApplicationCacheHost.h"
@@ skipping 147 matching lines @@
 
 void EmptyTextCheckerClient::requestCheckingOfString(TextCheckingRequest*) {}
 
 void EmptyTextCheckerClient::cancelAllPendingRequests() {}
 
 std::unique_ptr<WebServiceWorkerProvider>
 EmptyLocalFrameClient::createServiceWorkerProvider() {
   return nullptr;
 }
 
+ContentSettingsClient* EmptyLocalFrameClient::contentSettingsClient() {
+  return new ContentSettingsClient();

[dcheng, 2017/04/02 05:26:19]

It seems a little surprising that this creates a new one every time. Would it be
possible to just make this a member?

[kinuko, 2017/04/03 15:15:06]

Oh yes, this was a tentative code I was going to fix. Done.

+}
+
 std::unique_ptr<WebApplicationCacheHost>
 EmptyLocalFrameClient::createApplicationCacheHost(
     WebApplicationCacheHostClient*) {
   return nullptr;
 }
 
 EmptyRemoteFrameClient::EmptyRemoteFrameClient() = default;
 
 }  // namespace blink