Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: components/exo/compositor_frame_sink_holder.cc

Issue 2786643002: [exo]CompositorFrameSinkHolder calls WillDraw in DidReceiveCompositorFrameAck (Closed)
Patch Set: Move Presentation Callbacks Before UpdateSurface Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/exo/surface.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/exo/compositor_frame_sink_holder.cc
diff --git a/components/exo/compositor_frame_sink_holder.cc b/components/exo/compositor_frame_sink_holder.cc
index c21346fc51b71d6979652fc38cf8e9ba1c5c742b..8eeefe09060c57069f361e229e2bfa7fe9ecf203 100644
--- a/components/exo/compositor_frame_sink_holder.cc
+++ b/components/exo/compositor_frame_sink_holder.cc
@@ -42,6 +42,8 @@ void CompositorFrameSinkHolder::SetResourceReleaseCallback(
void CompositorFrameSinkHolder::DidReceiveCompositorFrameAck() {
// TODO(staraz): Implement this
reveman 2017/04/06 20:42:04 nit: remove this now?
Alex Z. 2017/04/06 20:49:13 Done.
+ if (surface_)
+ surface_->WillDraw();
Fady Samuel 2017/04/06 20:52:33 Rename WillDraw to DidReceiveCompositorFrameAck?
reveman 2017/04/06 21:09:06 +1
Alex Z. 2017/04/06 21:11:12 Done.
}
void CompositorFrameSinkHolder::OnBeginFrame(const cc::BeginFrameArgs& args) {
@@ -62,10 +64,7 @@ void CompositorFrameSinkHolder::ReclaimResources(
void CompositorFrameSinkHolder::WillDrawSurface(
const cc::LocalSurfaceId& local_surface_id,
- const gfx::Rect& damage_rect) {
- if (surface_)
- surface_->WillDraw();
-}
+ const gfx::Rect& damage_rect) {}
////////////////////////////////////////////////////////////////////////////////
// cc::ExternalBeginFrameSourceClient overrides:
« no previous file with comments | « no previous file | components/exo/surface.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698