Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2786593004: Use entities in NativeResolutionEnqueuer and make it reusable for kernel (Closed)

Created:
3 years, 8 months ago by Johnni Winther
Modified:
3 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use entities in NativeResolutionEnqueuer and make it reusable for kernel This is step towards computing closed world directly from kernel. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/9fd5ae5b81f6ca0f0594bb6b6da48e62c547691a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -73 lines) Patch
M pkg/compiler/lib/src/common_elements.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 5 chunks +20 lines, -6 lines 0 comments Download
A pkg/compiler/lib/src/kernel/native_class_resolver.dart View 1 chunk +18 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/no_such_method_resolver.dart View 1 chunk +6 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/kernel/world_builder.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 16 chunks +82 lines, -61 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 4 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 8 months ago (2017-03-29 14:08:11 UTC) #2
Emily Fortuna
lgtm
3 years, 8 months ago (2017-03-29 17:53:34 UTC) #3
Johnni Winther
3 years, 8 months ago (2017-04-03 08:33:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9fd5ae5b81f6ca0f0594bb6b6da48e62c547691a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698