Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2786513002: Remove useless PrintPreviewUI::OnShowSystemDialog(). (Closed)

Created:
3 years, 8 months ago by Lei Zhang
Modified:
3 years, 8 months ago
Reviewers:
dpapad, rbpotter
CC:
chromium-reviews, jzfeng
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove useless PrintPreviewUI::OnShowSystemDialog(). All it does is make a JS call to JS code that has not existed since before r138737. Review-Url: https://codereview.chromium.org/2786513002 Cr-Commit-Position: refs/heads/master@{#460270} Committed: https://chromium.googlesource.com/chromium/src/+/215c2ad55d7b2ccd4461033eb697abf0bd5c7f98

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -18 lines) Patch
M chrome/browser/printing/print_view_manager.cc View 1 chunk +1 line, -7 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Lei Zhang
jzfeng found this bit of dangling code in another CL. Not sure if there's a ...
3 years, 8 months ago (2017-03-29 01:42:59 UTC) #5
dpapad
lgtm
3 years, 8 months ago (2017-03-29 01:47:55 UTC) #6
rbpotter
On 2017/03/29 01:47:55, dpapad wrote: > lgtm lgtm
3 years, 8 months ago (2017-03-29 02:39:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2786513002/1
3 years, 8 months ago (2017-03-29 03:03:13 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 04:09:33 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/215c2ad55d7b2ccd4461033eb697...

Powered by Google App Engine
This is Rietveld 408576698