Fix a couple of bugs with async stack traces

Fix a couple of bugs with async stack traces

Related to #29145.

Fixes #29199.

1. Missing source positions in async and async* functions (synthetic code)

2. Added unit tests for issues #28980 and added asyns stack trace testing flags to existing test.

3. Handle uninitialized Completer object when collecting async stack traces.

Still missing is the correct calculation of context levels in ActivationFrame::ContextLevel. This is planned for a separate CL.

R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/5a3f9d9398877799c46ffeb0c1d5751a366cffe3

[Florian Schneider, 2017-03-29 00:33:20]

fschneider@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2017-03-29 13:50:18]

lgtm and thanks!

[Cutch, 2017-03-30 13:59:23]

This should probably be cherry picked into dev.

[Florian Schneider, 2017-03-30 15:58:47]

On 2017/03/30 13:59:23, Cutch wrote:
> This should probably be cherry picked into dev.

Yes, but I discovered another problem. We can discuss how to solve it offline.

[Florian Schneider, 2017-03-30 17:31:55]

Description was changed from

==========
Fix a couple of bugs with async stack traces

Fixes #29145.

1. Missing source positions in async and async* functions (synthetic code)

2. Fixed calculation of context level in async functions at the completeError
call.

3. Added unit tests for issues #28980 and added asyns stack trace testing flags
to existing test.

4. Handle uninitialized Completer object when collecting async stack traces.
==========

to

==========
Fix a couple of bugs with async stack traces

Related to #29145.

1. Missing source positions in async and async* functions (synthetic code)

2. Added unit tests for issues #28980 and added asyns stack trace testing flags
to existing test.

3. Handle uninitialized Completer object when collecting async stack traces.

Still missing is the correct calculation of context levels in
ActivationFrame::ContextLevel. This is planned for a separate CL.
==========

[Florian Schneider, 2017-03-30 17:46:08]

Description was changed from

==========
Fix a couple of bugs with async stack traces

Related to #29145.

1. Missing source positions in async and async* functions (synthetic code)

2. Added unit tests for issues #28980 and added asyns stack trace testing flags
to existing test.

3. Handle uninitialized Completer object when collecting async stack traces.

Still missing is the correct calculation of context levels in
ActivationFrame::ContextLevel. This is planned for a separate CL.
==========

to

==========
Fix a couple of bugs with async stack traces

Related to #29145.

Fixes #29199.

1. Missing source positions in async and async* functions (synthetic code)

2. Added unit tests for issues #28980 and added asyns stack trace testing flags
to existing test.

3. Handle uninitialized Completer object when collecting async stack traces.

Still missing is the correct calculation of context levels in
ActivationFrame::ContextLevel. This is planned for a separate CL.
==========

[Florian Schneider, 2017-03-30 18:02:38]

Description was changed from

==========
Fix a couple of bugs with async stack traces

Related to #29145.

Fixes #29199.

1. Missing source positions in async and async* functions (synthetic code)

2. Added unit tests for issues #28980 and added asyns stack trace testing flags
to existing test.

3. Handle uninitialized Completer object when collecting async stack traces.

Still missing is the correct calculation of context levels in
ActivationFrame::ContextLevel. This is planned for a separate CL.
==========

to

==========
Fix a couple of bugs with async stack traces

Related to #29145.

Fixes #29199.

1. Missing source positions in async and async* functions (synthetic code)

2. Added unit tests for issues #28980 and added asyns stack trace testing flags
to existing test.

3. Handle uninitialized Completer object when collecting async stack traces.

Still missing is the correct calculation of context levels in
ActivationFrame::ContextLevel. This is planned for a separate CL.

R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5a3f9d9398877799c46ffeb0c1d5751a366cffe3
==========

[Florian Schneider, 2017-03-30 18:02:40]

Committed patchset #3 (id:40001) manually as
5a3f9d9398877799c46ffeb0c1d5751a366cffe3 (presubmit successful).