Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2786483002: AOT compiler changes for dart_content_handler: (Closed)

Created:
3 years, 8 months ago by rmacnak
Modified:
3 years, 8 months ago
Reviewers:
zra, Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

AOT compiler changes for dart_content_handler: - Move some misplaced entry points from the vm list to the standalone embedder list. - Add missing libdart_with_precompiler to GN. - Add ability to reference the root library in treeshaking roots without knowing its URI (as ::). R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/95756576687bba755d3fff1d74ffae0d990d1ef7

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -13 lines) Patch
M runtime/BUILD.gn View 1 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/bin/main.cc View 1 2 chunks +12 lines, -8 lines 0 comments Download
M runtime/vm/BUILD.gn View 2 chunks +25 lines, -0 lines 0 comments Download
M runtime/vm/precompiler.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
rmacnak
3 years, 8 months ago (2017-03-28 22:43:57 UTC) #4
zra
lgtm
3 years, 8 months ago (2017-03-29 02:25:34 UTC) #5
rmacnak
3 years, 8 months ago (2017-03-29 17:12:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
95756576687bba755d3fff1d74ffae0d990d1ef7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698