Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: third_party/WebKit/Source/core/paint/PaintInvalidator.cpp

Issue 2786463004: Paint backgrounds of a table section/row in one display item (Closed)
Patch Set: First round of rebaseline-cl Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp b/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
index eeedfe7e0d7d5aceab040af5ea114e5c1f5e344b..eedbc7b62fff703c72969e5c3166a724c56beff5 100644
--- a/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintInvalidator.cpp
@@ -11,6 +11,7 @@
#include "core/layout/LayoutBlockFlow.h"
#include "core/layout/LayoutObject.h"
#include "core/layout/LayoutTable.h"
+#include "core/layout/LayoutTableSection.h"
#include "core/layout/LayoutView.h"
#include "core/layout/svg/SVGLayoutSupport.h"
#include "core/paint/ObjectPaintProperties.h"
@@ -235,6 +236,12 @@ void PaintInvalidator::updatePaintingLayer(const LayoutObject& object,
if (object == context.paintingLayer->layoutObject())
return;
+ if (object.isTableSection()) {
chrishtr 2017/03/31 22:59:06 This seems a weird place to invalidate paint phase
Xianzhu 2017/03/31 23:26:30 This is to update paint phase requirements of laye
chrishtr 2017/04/03 17:10:51 Yes, that makes more sense, thanks.
+ const auto& section = toLayoutTableSection(object);
+ if (section.table()->hasColElements())
wkorman 2017/03/31 22:15:41 If we change for prior comment would need to follo
+ context.paintingLayer->setNeedsPaintPhaseDescendantBlockBackgrounds();
+ }
+
if (object.styleRef().hasOutline())
context.paintingLayer->setNeedsPaintPhaseDescendantOutlines();

Powered by Google App Engine
This is Rietveld 408576698