Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2786423002: Store offsets in ModifierBuilders. (Closed)

Created:
3 years, 8 months ago by ahe
Modified:
3 years, 8 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M pkg/front_end/lib/src/fasta/builder/modifier_builder.dart View 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
ahe
Improves error messages wrt to fields.
3 years, 8 months ago (2017-03-31 15:29:56 UTC) #2
karlklose
LGTM
3 years, 8 months ago (2017-04-03 06:45:51 UTC) #3
ahe
3 years, 8 months ago (2017-04-04 12:53:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
376c5e2d0b5379ce7e50eddaf092515198a50f73 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698