Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 278633003: Extracted UsbDeviceHandle as interface. (Closed)

Created:
6 years, 7 months ago by Dmitry Zvorygin
Modified:
6 years, 7 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Visibility:
Public.

Description

Extracted UsbDeviceHandle as interface. BUG=367094 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269803

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -906 lines) Patch
M chrome/browser/devtools/device/usb/android_usb_device.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/usb_service.gypi View 1 chunk +2 lines, -1 line 0 comments Download
M components/usb_service/usb_device_handle.h View 4 chunks +13 lines, -89 lines 0 comments Download
D components/usb_service/usb_device_handle.cc View 1 chunk +0 lines, -659 lines 0 comments Download
A + components/usb_service/usb_device_handle_impl.h View 6 chunks +37 lines, -67 lines 0 comments Download
A + components/usb_service/usb_device_handle_impl.cc View 22 chunks +74 lines, -73 lines 0 comments Download
M components/usb_service/usb_device_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/usb_service/usb_device_impl.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M extensions/browser/api/usb/usb_api.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M extensions/browser/api/usb/usb_apitest.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Dmitry Zvorygin
Please take a look.
6 years, 7 months ago (2014-05-08 17:47:43 UTC) #1
Ken Rockot(use gerrit already)
usb_service and usb API LGTM.
6 years, 7 months ago (2014-05-09 23:58:33 UTC) #2
Vladislav Kaznacheev
lgtm
6 years, 7 months ago (2014-05-12 14:46:26 UTC) #3
Dmitry Zvorygin
The CQ bit was checked by zvorygin@chromium.org
6 years, 7 months ago (2014-05-12 14:47:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zvorygin@chromium.org/278633003/1
6 years, 7 months ago (2014-05-12 14:47:20 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-12 16:58:58 UTC) #6
Message was sent while issue was closed.
Change committed as 269803

Powered by Google App Engine
This is Rietveld 408576698